GNOME Bugzilla – Bug 767960
Regression for theming of xchat/hexchat's input box
Last modified: 2018-01-24 14:55:33 UTC
In [he]xchat there is an option in Preferences > Input box > Use text box font and colors that dynamically modifies the gtk theme. This worked in 3.18 but 3.20 does not. git bisect led me to https://git.gnome.org/browse/gnome-themes-standard/commit/?id=ba9c19414b0efbc0636996a3ce14a53772832e7e which does have mention of the widget "*xchat-inputbox". Alternatively if you know a better way for the application to handle this that would be ok too.
Hey, I removed the [he]xchat hack with a bunch of others since they were really old and usually long fixed, only to find out several months later that the issue was still there, but I haven't got to adding it back. Funnily enough it has nothing to do with this bug. It's about the bug with entries having a white area around themselves, but if you are interested in fixing it just put the affected entries inside a GtkEventBox. Sadly _this_ bug is a WONTFIX. I've covered the details in #767562. I'm not sure what you can do from the application but overriding the theme not to use the entry assets should do it, at the expense of losing the look. The only real solution is to switch to gtk3. Cheers.
> overriding the theme not to use the entry assets should do it How exactly would you do that? I tried copying what you posted in #767562 but it didn't seem to work.
Nevermind I did get that to work though it still has the border you were mentioning any tips on how to get rid of that. http://i.imgur.com/DgxEXwk.png
(In reply to Patrick Griffis (tingping) from comment #3) > Nevermind I did get that to work How? I'm quite curious. > though it still has the border you were > mentioning > any tips on how to get rid of that. IIRC you need to lower the border values for the entry-border.png, but it'll cut of the corners. However that's pulled deep from my memory so it may not be correct. I'll get back to you tomorrow.
(In reply to Juraj Fiala from comment #4) > (In reply to Patrick Griffis (tingping) from comment #3) > > Nevermind I did get that to work > > How? I'm quite curious. > engine "pixmap" { image { function = FLAT_BOX state = NORMAL } image { function = FLAT_BOX state = ACTIVE } }
(In reply to Patrick Griffis (tingping) from comment #5) > engine "pixmap" { > image { > function = FLAT_BOX > state = NORMAL > } > image { > function = FLAT_BOX > state = ACTIVE > } > } But I mean did you do this from the application side or just manually patch the file?
(In reply to Juraj Fiala from comment #6) > But I mean did you do this from the application side or just manually patch > the file? gtk_rc_parse_string()
Why do I do this everytime? I know this is a very late "tomorrow" but I'll answer anyway: I've thought about this and the best way to fix this without ruining the experience for 99% of applications is to override with your own entry assets that do enable changing the background. If you want I can make these assets for along with the rc segment to get them working.
I've already been shipping that workaround for months and honestly seems fine.
Sure you don't want the assets? Just tried it, seems fine, but it would look a bit better.
If you already put in the work I suppose it is worth a shot.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-themes-extra/issues/5.