After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767959 - Remove hard dependency on Nokia mediaart service
Remove hard dependency on Nokia mediaart service
Status: RESOLVED FIXED
Product: libmediaart
Classification: Other
Component: Extraction
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libmediaart maintainer(s)
libmediaart maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-22 20:30 UTC by Jens Georg
Modified: 2017-07-01 04:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
extract: Remove Nokia album art downloader support (6.35 KB, patch)
2016-06-22 20:47 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2016-06-22 20:30:05 UTC 
I'm trying to use libmediaart in an environment without a session bus and I'm not able to create an extracting process because creating the D-Bus connection to session bus fails. I'm sure we can live without it.

Is there even anyone offering the Nokia interface now?
Comment 1 Jens Georg 2016-06-22 20:47:25 UTC 
Created attachment 330217 [details] [review]
extract: Remove Nokia album art downloader support
Comment 2 Jens Georg 2016-06-22 20:48:16 UTC 
Proposed patch. If you prefer keeping it, I can cook one that doesn't make the non-existence of the connection fatal.
Comment 3 Jens Georg 2016-09-23 18:05:21 UTC 
Hm. That seems to be half the truth. Libmediaart locks up if there's no session dbus in storage_init due to the mount monitor:

+ Trace 236692

  • #0 syscall
    at ../sysdeps/unix/sysv/linux/x86_64/syscall.S line 38
  • #1 g_cond_wait
    at /home/jens/jhbuild/checkout/glib/glib/gthread-posix.c line 1395
  • #2 g_context_specific_group_request_state
    at /home/jens/jhbuild/checkout/glib/gio/gcontextspecificgroup.c line 157
  • #3 g_context_specific_group_get
    at /home/jens/jhbuild/checkout/glib/gio/gcontextspecificgroup.c line 202
  • #4 g_unix_mount_monitor_get
    at /home/jens/jhbuild/checkout/glib/gio/gunixmounts.c line 1787
  • #5 g_unix_volume_monitor_init
    at /home/jens/jhbuild/checkout/glib/gio/gunixvolumemonitor.c line 212
  • #6 g_type_create_instance
    at /home/jens/jhbuild/checkout/glib/gobject/gtype.c line 1866
  • #7 g_object_new_internal
    at /home/jens/jhbuild/checkout/glib/gobject/gobject.c line 1783
  • #8 g_object_newv
    at /home/jens/jhbuild/checkout/glib/gobject/gobject.c line 1930
  • #9 g_object_new
    at /home/jens/jhbuild/checkout/glib/gobject/gobject.c line 1623
  • #10 populate_union_monitor
    at /home/jens/jhbuild/checkout/glib/gio/gunionvolumemonitor.c line 519
  • #11 g_volume_monitor_get
    at /home/jens/jhbuild/checkout/glib/gio/gunionvolumemonitor.c line 571
  • #12 storage_init
    at storage.c line 154 






Comment 4


Jens Georg





          2016-09-23 18:15:43 UTC
        



is there actually anything using the storage?






Comment 5


Jens Georg





          2016-09-23 18:42:47 UTC
        



Ah, storage is a leftover from the mediaartlocal removal. So it can probably go as well unless it is needed for bug 752054






Comment 6


Sam Thursfield





          2017-06-08 18:08:00 UTC
        



Review of attachment 330217 [details] [review]:

It looks good to me. Downloading album art is a nice feature to have but I think relying on a Nokia-specific D-Bus service is not the way to do it :-)






Comment 7


Carlos Garnacho





          2017-06-08 20:36:18 UTC
        



Review of attachment 330217 [details] [review]:

Let's go with it :). Thanks Jens for the patch!






Comment 8


Carlos Garnacho





          2017-06-08 20:37:36 UTC
        



(In reply to Sam Thursfield from comment #6)
> Review of attachment 330217 [details] [review] [review]:
> 
> It looks good to me. Downloading album art is a nice feature to have but I
> think relying on a Nokia-specific D-Bus service is not the way to do it :-)

I agree with this, there's some feature overlap with grilo, but I'm sure they'd be happy to move to libmediaart if it solved the issue for them :)






Comment 9


Jens Georg





          2017-06-30 19:19:37 UTC
        



Attachment 330217 [details] pushed as 099bbdf - extract: Remove Nokia album art downloader support






Comment 10


Carlos Garnacho





          2017-06-30 22:22:41 UTC
        



\o/, thanks! I'll do a release shortly






Comment 11


Jens Georg





          2017-07-01 04:59:57 UTC
        



Sorry, I didn't pay attention, I assumed you guys already pushed it.