After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767896 - no icon in about dialog (using flatpak nightly)
no icon in about dialog (using flatpak nightly)
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-21 03:02 UTC by Andreas Nilsson
Modified: 2016-07-16 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (67.85 KB, image/png)
2016-06-21 03:02 UTC, Andreas Nilsson 		  Details
icons: rename Builder icon to the application id (5.55 KB, patch)
2016-07-15 20:53 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Andreas Nilsson 2016-06-21 03:02:08 UTC 
Created attachment 330111 [details]
screenshot

No icon in about dialog (using flatpak nightly).
All other graphics seems to look OK.
Comment 1 Matthew Leeds 2016-07-15 20:53:00 UTC 
Created attachment 331612 [details] [review]
icons: rename Builder icon to the application id

This commit changes the Builder icon file name from "builder.png" to
"org.gnome.Builder.png", which allows Builder to access its own icon
for the About Dialog when running under Flatpak.
Comment 2 Matthew Leeds 2016-07-15 20:55:19 UTC 
Once that patch has been pushed, I'll submit a PR to the gnome-apps-nightly repo to remove the rename-icon line from org.gnome.Builder.json.
Comment 3 Christian Hergert 2016-07-15 22:01:39 UTC 
Review of attachment 331612 [details] [review]:

LGTM