After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767895 - Improve annotation window ui
Improve annotation window ui
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: pdf annotations
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-21 02:44 UTC by Trinh Anh Ngoc
Modified: 2018-05-22 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improve annotation window ui (4.94 KB, patch)
2016-06-21 02:44 UTC, Trinh Anh Ngoc 		none Details | Review
Annotation window screenshot (14.74 KB, image/png)
2016-06-21 02:50 UTC, Trinh Anh Ngoc 		  Details
Improve annotation properties dialog ui (4.56 KB, patch)
2016-06-21 02:57 UTC, Trinh Anh Ngoc 		committed Details | Review
Annotation properties window screenshot (46.19 KB, image/png)
2016-06-21 02:58 UTC, Trinh Anh Ngoc 		  Details

Description Trinh Anh Ngoc 2016-06-21 02:44:17 UTC 
Created attachment 330107 [details] [review]
Improve annotation window ui

Annotation window currently doesn't play well with dark theme (https://bugzilla.gnome.org/show_bug.cgi?id=763944).
Comment 1 Trinh Anh Ngoc 2016-06-21 02:50:07 UTC 
Created attachment 330108 [details]
Annotation window screenshot
Comment 2 Trinh Anh Ngoc 2016-06-21 02:57:28 UTC 
Created attachment 330109 [details] [review]
Improve annotation properties dialog ui
Comment 3 Trinh Anh Ngoc 2016-06-21 02:58:29 UTC 
Created attachment 330110 [details]
Annotation properties window screenshot
Comment 4 Carlos Garcia Campos 2016-07-16 10:27:32 UTC 
(In reply to Trinh Anh Ngoc from comment #0)
> Created attachment 330107 [details] [review] [review]
> Improve annotation window ui
> 
> Annotation window currently doesn't play well with dark theme
> (https://bugzilla.gnome.org/show_bug.cgi?id=763944).

I don't think annotation windows should follow the theme at all, they have their own appearance based on the annotation properties. What we should do, though, is ensuring the window title is readable, and adjust the font color accordingly, instead of using the one from the theme.
Comment 5 Carlos Garcia Campos 2016-07-16 10:31:55 UTC 
Comment on attachment 330109 [details] [review]
Improve annotation properties dialog ui

I pushed this one, thanks!
Comment 6 GNOME Infrastructure Team 2018-05-22 16:42:28 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/689.