After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767878 - zoom level written out even if user has made no change
zoom level written out even if user has made no change
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
3.20.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-20 16:28 UTC by Mike Gorse
Modified: 2016-06-20 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (2.41 KB, patch)
2016-06-20 16:35 UTC, Mike Gorse 		committed Details | Review

Description Mike Gorse 2016-06-20 16:28:11 UTC 
Nautilus writes the zoom level being used to gsettings as a side effect of initialization, whether the user has made a change or not. We noticed this while preparing a service pack for SUSE Linux Enterprise Desktop that updates the GNOME stack, since, if a system is updated and then rolled back, then the system default from the new version is still present in the user configuration. I am going to apply a patch there to make nautilus only write out the setting if it is different from the current setting.
Comment 1 Mike Gorse 2016-06-20 16:35:11 UTC 
Created attachment 330091 [details] [review]
Proposed patch.
Comment 2 Carlos Soriano 2016-06-20 18:00:57 UTC 
Review of attachment 330091 [details] [review]:

oh just realised gsettings is a tri-state...

LGTM Feel free to commit to both master and 3.20
Comment 3 Mike Gorse 2016-06-20 19:51:45 UTC 
Comment on attachment 330091 [details] [review]
Proposed patch.

Thanks foer the review.

master: f18846
gnome-3-20: 586610