After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767853 - Use GtkActionBar in sidebar
Use GtkActionBar in sidebar
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-20 05:52 UTC by Trinh Anh Ngoc
Modified: 2018-05-22 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port top option menu sidebar to GtkActionBar (3.66 KB, patch)
2016-06-20 05:58 UTC, Trinh Anh Ngoc 		none Details | Review
Port sidebar bookmarks action box to GtkActionBar (2.88 KB, patch)
2016-06-20 05:59 UTC, Trinh Anh Ngoc 		none Details | Review
Screenshot (15.32 KB, image/png)
2016-06-20 06:00 UTC, Trinh Anh Ngoc 		  Details
Improve sidebar top option menu (1.72 KB, patch)
2016-06-22 13:03 UTC, Trinh Anh Ngoc 		committed Details | Review

Description Trinh Anh Ngoc 2016-06-20 05:52:36 UTC 
This makes sidebar UI a bit better.
Comment 1 Trinh Anh Ngoc 2016-06-20 05:58:07 UTC 
Created attachment 330045 [details] [review]
Port top option menu sidebar to GtkActionBar

With GtkActionBar, we can pack menu button in center of it.
Comment 2 Trinh Anh Ngoc 2016-06-20 05:59:53 UTC 
Created attachment 330046 [details] [review]
Port sidebar bookmarks action box to GtkActionBar
Comment 3 Trinh Anh Ngoc 2016-06-20 06:00:33 UTC 
Created attachment 330047 [details]
Screenshot
Comment 4 Trinh Anh Ngoc 2016-06-22 13:03:48 UTC 
Created attachment 330188 [details] [review]
Improve sidebar top option menu

Keep using GtkBox instead of GtkActionBar.
Always center menu button.
Increase margins.
Comment 5 Carlos Garcia Campos 2016-07-16 10:11:24 UTC 
(In reply to Trinh Anh Ngoc from comment #3)
> Created attachment 330047 [details]
> Screenshot

I don't see why this is better than the centered linked buttons. Could you elaborate more on what this is improving?
Comment 6 Carlos Garcia Campos 2016-07-16 10:23:20 UTC 
Comment on attachment 330188 [details] [review]
Improve sidebar top option menu

Ok, pushed this one, thanks!
Comment 7 Trinh Anh Ngoc 2016-07-17 00:28:37 UTC 
(In reply to Carlos Garcia Campos from comment #5)
> (In reply to Trinh Anh Ngoc from comment #3)
> > Created attachment 330047 [details]
> > Screenshot
> 
> I don't see why this is better than the centered linked buttons. Could you
> elaborate more on what this is improving?

I think that conforms to GNOME 3 HIG (https://developer.gnome.org/hig/stable/action-bars.html.en). By default GtkActionBar has top border and it's child widgets have consistent margins.
Comment 8 GNOME Infrastructure Team 2018-05-22 16:42:01 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/688.