After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767812 - Please don't list 'Taiwan' as 'Taiwan, Province of China' in the country list
Please don't list 'Taiwan' as 'Taiwan, Province of China' in the country list
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-18 11:10 UTC by Ting-Wei Lan
Modified: 2016-06-20 04:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GladeRegistration: Use 'Taiwan' to list Taiwan (1.35 KB, patch)
2016-06-18 11:11 UTC, Ting-Wei Lan
none Details | Review

Description Ting-Wei Lan 2016-06-18 11:10:29 UTC
Most Taiwanese consider 'Taiwan, Province of China' incorrect and offensive. Can we change it? Some software avoid this problem by preferring 'common_name' to 'name' when generating the list from ISO 3166.
Comment 1 Ting-Wei Lan 2016-06-18 11:11:14 UTC
Created attachment 329991 [details] [review]
GladeRegistration: Use 'Taiwan' to list Taiwan

'Taiwan, Province of China' is a controversial and misleading term
that should be avoided. Unfortunately, It is already widely used
because its inclusion in ISO 3166 and we have no way to change it.
Comment 2 Juan Pablo Ugarte 2016-06-19 19:05:25 UTC
Sorry for the inconvenience, I intentionally used ISO 3166 instead of a random country list from the internet to avoid this kind of situation, but evidently that did not help much.

I used this free file to generate the list

http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements_txt-temp.htm

which unfortunately does not have 'common_name' column.

Is it possible to find the full db for free?

Anyways I already pushed a fix to master, and I will request a string break for the stable version ASAP

thanks
Comment 3 Christian Persch 2016-06-19 19:18:55 UTC
glade should use iso-codes [https://anonscm.debian.org/cgit/pkg-isocodes/iso-codes.git/] to get this list, by parsing the data/iso_3166-1.json file at runtime (or at build time), and using the translations from the iso-codes gettext domain to translate them at runtime.
Comment 4 Ting-Wei Lan 2016-06-20 04:32:13 UTC
(In reply to Christian Persch from comment #3)
> glade should use iso-codes
> [https://anonscm.debian.org/cgit/pkg-isocodes/iso-codes.git/] to get this
> list, by parsing the data/iso_3166-1.json file at runtime (or at build
> time), and using the translations from the iso-codes gettext domain to
> translate them at runtime.

Yes, I assumed the list was generated from data provided by isocodes package.