GNOME Bugzilla – Bug 767805
Make display config timeout configurable
Last modified: 2017-07-31 14:45:57 UTC
Right now both gnome-shell and mutter hardcode it separately. Instead, make this configurable through a GSetting.
Created attachment 329982 [details] [review] prefs: fix a couple of typos It's "threshold", not "trheshold". Also, make sure to add the enum value to the documentation section.
Created attachment 329983 [details] [review] prefs: add a setting for the display configuration timeout Instead of hardcoding this into two different places, make it a GSetting. This will also allow distributors (and users) to specify a different timeout if wanted.
Created attachment 329984 [details] [review] windowManager: use meta_pref_get_display_configuration_timeout() Instead of hardcoding a 20 seconds limit.
Any opinion on these patches?
Friendly ping for review on these.
(In reply to Cosimo Cecchi from comment #0) > Right now both gnome-shell and mutter hardcode it separately. > Instead, make this configurable through a GSetting. Does it really need to be configurable? Why not just add mutter API so that gnome-shell doesn't need to guess?
(In reply to Jonas Ådahl from comment #6) > Does it really need to be configurable? Why not just add mutter API so that > gnome-shell doesn't need to guess? I could just add the API, but we set it to a higher value on Endless, so it made sense to just add a simple setting.
Jonas or others: any other thoughts on these patches?
Patches still apply to 3.24.
Created attachment 356649 [details] [review] monitor-manager: add API to get the display configuration timeout Instead of hardcoding this into two different places, add an API so that gnome-shell can fetch it.
Created attachment 356650 [details] [review] windowManager: use Meta.MonitorManager.get_display_configuration_timeout() Instead of hardcoding a 20 seconds limit.
These new patches remove the gsetting, after discussing with Florian, but keep the API so that the setting does not have to be hardcoded in two places.
Created attachment 356651 [details] [review] monitor-manager: add API to get the display configuration timeout Instead of hardcoding this into two different places, add an API so that gnome-shell can fetch it.
Review of attachment 329982 [details] [review]: Whoops
Review of attachment 356651 [details] [review]: LGTM
Review of attachment 356650 [details] [review]: OK
Attachment 329982 [details] pushed as 4c1fe4c - prefs: fix a couple of typos Attachment 356651 [details] pushed as 1455c40 - monitor-manager: add API to get the display configuration timeout
Attachment 356650 [details] pushed as c1e478e - windowManager: use Meta.MonitorManager.get_display_configuration_timeout()