After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767803 - Crash in try_pixmap_and_mask
Crash in try_pixmap_and_mask
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-17 21:42 UTC by Alberts Muktupāvels
Modified: 2016-06-21 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xutils: add error trap in try_pixmap_and_mask (1.65 KB, patch)
2016-06-17 21:42 UTC, Alberts Muktupāvels 		none Details | Review
xutils: add error trap in try_pixmap_and_mask (1.32 KB, patch)
2016-06-17 21:52 UTC, Alberts Muktupāvels 		committed Details | Review

Description Alberts Muktupāvels 2016-06-17 21:42:34 UTC 
Created attachment 329975 [details] [review]
xutils: add error trap in try_pixmap_and_mask

https://bugs.freedesktop.org/show_bug.cgi?id=91967
This cairo bug has reproducer that can trigger X error in libwnck.
Comment 1 Alberts Muktupāvels 2016-06-17 21:52:20 UTC 
Created attachment 329976 [details] [review]
xutils: add error trap in try_pixmap_and_mask

Updated patch. _wnck_cairo_surface_get_from_pixmap is already protected with error trap so no need to include that part...
Comment 2 Wolfgang Ulbrich 2016-06-18 10:26:41 UTC 
Just tested on fedora 24 with
- cairo-1.14.6 + your patch from cairo report
- libwnck-3.18.0 + the second patch
- running test3.py reproducer

Mate wnck applets or mate-panel don't crash any more.
But the whole desktop can easily freeze if i try to open another window if test3.py is running.
This didn't happen without 'add error trap in try_pixmap_and_mask'.
Comment 3 Marco Trevisan (Treviño) 2016-06-21 13:11:32 UTC 
Review of attachment 329976 [details] [review]:

Looks good, thanks
Comment 4 Marco Trevisan (Treviño) 2016-06-21 13:14:19 UTC 
Review of attachment 329976 [details] [review]:

+1