After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767789 - rtph264pay: Deprecated sprop-parameter-set property
rtph264pay: Deprecated sprop-parameter-set property
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
Other All
: Normal minor
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2016-06-17 12:30 UTC by Sebastian Dröge (slomo)
Modified: 2016-06-21 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

rtph264pay: Deprecated sprop-parameter-set property (1.16 KB, patch)
2016-06-17 12:30 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2016-06-17 12:30:44 UTC
See commit message. Independent of this it might make sense to add the SPS/PPS
(and VPS for h265) to a streamheaders caps field in byte-stream.
Comment 1 Sebastian Dröge (slomo) 2016-06-17 12:30:49 UTC
Created attachment 329946 [details] [review]
rtph264pay: Deprecated sprop-parameter-set property

This is supposed to be either in the codec_data (avc stream format) or inside
the stream, and we extract it from there. It should not be set from a
property as it's stream specific.
Comment 2 Sebastian Dröge (slomo) 2016-06-17 12:32:07 UTC
Comments, ideas? :)
Comment 3 Jonas Holmberg 2016-06-17 20:09:04 UTC
I think setting the property is a bug and applications that do ought to be fixed. Reading the propery might be ok, but there are other, more correct ways to obtain the value.

So removing it in 1.10 or 1.12 seems like a good idea.
Comment 4 Sebastian Dröge (slomo) 2016-06-21 07:03:16 UTC
Attachment 329946 [details] pushed as 5f2b32e - rtph264pay: Deprecated sprop-parameter-set property