After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767780 - The "References" header folded twice
The "References" header folded twice
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
3.20.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 768727 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-06-17 09:03 UTC by benh
Modified: 2016-07-18 09:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description benh 2016-06-17 09:03:59 UTC
I have add people complaining that some of my emails had weird bits of headers at the beginning.

It looks like some blank lines got inserted in the header causing this. An example (sorry I can't provide the complete msg but only selected bits of header, I'll provide more if you tell me what you need):

Original message received:

 .../...
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
Message-Id: <OF34C985F2.0161055F-ONC1257FD4.0046B798-C1257FD4.004AD65A@notes.na.collabserv.com>
X-TM-AS-MML: disable
X-Evolution-POP3-UID: 508550bd0001d2f9
X-Evolution-Source: 1285223452.2025.1@pasglop

Headers of the message in my sendbox after doing "Reply" in evo:

.../...
Date: Fri, 17 Jun 2016 07:20:20 +1000
In-Reply-To: <OF34C985F2.0161055F-ONC1257FD4.0046B798-C1257FD4.004AD65A@notes.na.collabserv.com>
References: <1466035623.30200.61.camel@au1.ibm.com>
        
         <OF34C985F2.0161055F-ONC1257FD4.0046B798-C1257FD4.004AD65A@notes.na.collabserv.com>
Organization: IBM Australia

You can see the References: field now contains a blank line which just contains a "tab" (as far as I can tell, it looks like spaces here but when saved & opened with a text editor it's a tab).

This subsequently gets mangled back through our email infrastructure to the point where headers gets broken up in two. I suspect there are additional problems in our infra but why adding that blank line in the first place ?
Comment 1 Milan Crha 2016-06-20 13:38:02 UTC
Thanks for a bug report. I guess this is caused by the change in bug #235681, which is at least quite close to the place where I'd expect the issue. Could you paste the In-Reply-To and References headers from the original message too, please? There is not needed the whole message, only these two headers are needed.
Comment 2 benh 2016-06-21 02:04:24 UTC
Ok so I've verified that the headers generated by evolution has spurrious blank lines in the "References", *however* those are valid blank lines, ie, they start with spaces.

So the actual *bug* is in the IBM email infrastructure who doesn't treat those well and turns some of them into actual blank lines, thus breaking the header.

That being said, what evolution does is weird and leads to funky looking headers, so it would be worthwhile fixing as well.

This is a header portion of a message I reply to. It has no references at this stage.

CC: xxxx
From: xxxxx
Date: Mon, 20 Jun 2016 17:02:20 -0500
X-KeepSent: 9617D140:327AD024-86257FD8:0078CD42;
 type=4; name=$KeepSent
X-Mailer: IBM Notes Release 9.0.1EXT SHF692 April 27, 2016
X-MailFwdBy: CN=Benjamin Herrenschmidt/OU=Australia/O=IBM
Auto-Submitted: auto-forwarded
X-LLNOutbound: False
X-Disclaimed: 41387
X-TNEFEvaluated: 1
Content-type: multipart/related; 
        Boundary="0__=8FBBF54BDFEA94B18f9e8a93df938690918c8FBBF54BDFEA94B1"
x-cbid: 16062022-0005-0000-0000-0000067714B0
X-IBM-ISS-SpamDetectors: Score=0.366849; BY=0; FL=0; FP=0; FZ=0; HX=0;
 KW=0; PH=0; SC=0.366849; ST=0; TS=0; UL=0; ISC=
X-IBM-ISS-DetailInfo: BY=3.00005411; HX=3.00000240; KW=3.00000007;
 PH=3.00000004; SC=3.00000170; SDB=6.00719143; UDB=6.00335489;
 UTC=2016-06-20 22:02:26
x-cbparentid: 16062022-9588-0000-0000-000004387620
Message-Id: <OF9617D140.327AD024-ON86257FD8.0078CD42-86257FD8.00791086@notes.na.collabserv.com>
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
X-TM-AS-MML: disable
X-Evolution-POP3-UID: 508550bd0001d3e7
X-Evolution-Source: 1285223452.2025.1@pasglop

Now this is a header portion after doing "reply" in evolution:

Message-ID: <1466461060.24271.168.camel@au1.ibm.com>
Subject: xxxxx
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
Reply-To: benh@au1.ibm.com
To: xxxx
Cc: xxxx
Date: Tue, 21 Jun 2016 08:17:40 +1000
In-Reply-To: <OF9617D140.327AD024-ON86257FD8.0078CD42-86257FD8.00791086@notes.na.collabserv.com>
References:
         
        <OF9617D140.327AD024-ON86257FD8.0078CD42-86257FD8.00791086@notes.na.collabserv.com>
Organization: IBM Australia
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.3 (3.20.3-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Evolution-Identity: 1357100475.2453.6@pasglop
X-Evolution-Fcc: folder://local/Sent
X-Evolution-Transport: 1357100475.2453.7@pasglop
X-Evolution-Source-Folder: folder://local/Secure/IBM
X-Evolution-Source-Message: 1466460369.24271_43012.pasglop
X-Evolution-Source-Flags: ANSWERED ANSWERED_ALL SEEN 
X-Evolution-Source: 

You can see the line of spaces being added.
Comment 3 Milan Crha 2016-06-21 07:04:43 UTC
I see, it's because the Message-ID is too long, thus it's folded in this odd way. I have a message with a shorter message id and it is not folded this way.
Comment 4 David Woodhouse 2016-06-21 08:34:22 UTC
I can understand putting the Message-Id on a line of its own instead of directly after the References: header, if that saves us a few characters. But that still doesn't justify having an additional blank line in the middle.
Comment 5 Milan Crha 2016-06-21 08:39:58 UTC
I made changes in both evolution-data-server and evolution finally.
The eds part avoids double-folding when the References header is already folded.
The evo part unfolds the References header before using it in the composer.
The side effect is that the References folder can force folding in certain situations, thus not preserve what is written in the message on the disk/server.

Created commit 4bf7ae5 in eds master (3.21.4+)
Created commit_dc0cca8 in evo master (3.21.4+) [1]

Created commit a614b36 in eds gnome-3-20 (3.20.4+)
Created commit_bc61bf9 in evo gnome-3-20 (3.20.4+)

[1] https://git.gnome.org/browse/evolution/commit/?id=dc0cca8
Comment 6 benh 2016-06-21 09:30:14 UTC
Thanks, I'll try the 3.20 version asap. I'm using Fedora, so currently at 3.20.3
Comment 7 Chris Smart 2016-06-21 12:28:18 UTC
Confirming that with the patches applied on top of 3.20.3 (Fedora 24 at least), the references header wrapping disappears.

Before patch:

[snip]
In-Reply-To: <31502d44-4cee-8432-317a-dff14df8721c@gmail.com>
References: <20160616233340.GA14449@distroguy.com>
»·······
»·······
 <13e8530c-80d6-5475-f4f2-3a46e4a75a76@gmail.com>
»·······
»·······
 <20160619234823.GA27442@distroguy.com>
»·······
»······· <31502d44-4cee-8432-317a-dff14df8721c@gmail.com>
X-Evolution-Source-Folder:

After patch:

[snip]
In-Reply-To: <31502d44-4cee-8432-317a-dff14df8721c@gmail.com>
References: <20160616233340.GA14449@distroguy.com>
»······· <13e8530c-80d6-5475-f4f2-3a46e4a75a76@gmail.com>
»······· <20160619234823.GA27442@distroguy.com>
»······· <31502d44-4cee-8432-317a-dff14df8721c@gmail.com>
X-Evolution-Source-Folder:

Hopefully other random mail servers won't mangle it now :-) Thanks!
Comment 8 Milan Crha 2016-07-18 09:16:06 UTC
*** Bug 768727 has been marked as a duplicate of this bug. ***
Comment 9 benh 2016-07-18 09:22:12 UTC
I confirm using Chris builds, it works for me. Thanks a lot !

(I should have sent that a month ago, sorry about that !)