After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767763 - Docs need an update: changes in Desturate tool
Docs need an update: changes in Desturate tool
Status: RESOLVED FIXED
Product: GIMP-manual
Classification: Other
Component: General
2.10
Other All
: Normal normal
: 2.10
Assigned To: Alexandre Prokoudine
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-06-16 22:56 UTC by Alexandre Prokoudine
Modified: 2017-03-28 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to update desaturate.xml (1.06 MB, patch)
2017-03-27 16:07 UTC, Elle Stone 		none Details | Review

Description Alexandre Prokoudine 2016-06-16 22:56:43 UTC 
- Turn the Desaturate tool into a normal GEGL filter
- Move it to 'Colors -> Desaturate'
Comment 1 Alexandre Prokoudine 2017-01-29 02:31:32 UTC 
https://git.gnome.org/browse/gimp-help-2/commit/?id=7cf4de2ce666108139493155aa7e173df386c4ca

Options still need updating.
Comment 2 Michael Schumacher 2017-02-28 20:45:27 UTC 
qa contact change to bugs@gimp.org
Comment 3 Michael Schumacher 2017-02-28 22:27:11 UTC 
setting target milestone 2.10
Comment 4 Elle Stone 2017-03-27 16:07:40 UTC 
Created attachment 348810 [details] [review]
patch to update desaturate.xml

I've never made a patch for gimp-help before, and this patch has a whole binary section, about which I have no clue.
Comment 5 Elle Stone 2017-03-27 17:55:28 UTC 
My patch applies cleanly to a fresh clone of git clone git://git.gnome.org/gimp-help-2.

This is what the resulting html page looks like:
http://ninedegreesbelow.com/files/desaturate/8-18-desaturate.html

gitg looks good.

The xml file validates.

Is there any reason why I shouldn't go ahead and (try to) push the patch?
Comment 6 Michael Natterer 2017-03-27 19:50:05 UTC 
Without even looking at the patch, go ahead :)

You can basically roam freely in the help files, they are mostly
quite out of date and can only be improved.