After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767747 - Window-management related fixes
Window-management related fixes
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-16 20:49 UTC by Cosimo Cecchi
Modified: 2016-06-19 07:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: don't use a thumbnail as window icon (4.84 KB, patch)
2016-06-16 20:49 UTC, Cosimo Cecchi 		committed Details | Review
application: parent the about dialog to the currently active window (1.44 KB, patch)
2016-06-16 20:49 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-06-16 20:49:51 UTC 
See attached patches. The former should improve the experience for desktop environments that don't have support for app menus, and the second one is a consistency fix with other applications such as eog or gedit.
Comment 1 Cosimo Cecchi 2016-06-16 20:49:54 UTC 
Created attachment 329915 [details] [review]
window: don't use a thumbnail as window icon

Modern desktop environments already have window previews e.g. in the
Alt-Tab interface (or in the Activities overview, in case of
gnome-shell).
For desktop environments that don't support an app menu, this also has
the effect of making the "application icon" used for the menu that
appears in the top-left window corner be the thumbnail, which is
confusing and unclear.

Just remove the code that changes the window icon.
Comment 2 Cosimo Cecchi 2016-06-16 20:49:57 UTC 
Created attachment 329916 [details] [review]
application: parent the about dialog to the currently active window

Instead of letting it go unparented, which is discouraged and
inconsistent with other similar apps.
Comment 3 Carlos Garcia Campos 2016-06-19 07:29:18 UTC 
Comment on attachment 329915 [details] [review]
window: don't use a thumbnail as window icon

Yes, I agree, pushed!
Comment 4 Carlos Garcia Campos 2016-06-19 07:29:44 UTC 
Comment on attachment 329916 [details] [review]
application: parent the about dialog to the currently active window

Ok, pushed too, thank you.