After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767722 - gtkrevealer: support minimum size of child
gtkrevealer: support minimum size of child
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-06-16 08:35 UTC by Carlos Soriano
Modified: 2018-05-02 17:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkrevealer: support minimum size of child (3.43 KB, patch)
2016-06-16 08:35 UTC, Carlos Soriano 		none Details | Review

Description Carlos Soriano 2016-06-16 08:35:23 UTC 
.
Comment 1 Carlos Soriano 2016-06-16 08:35:28 UTC 
Created attachment 329895 [details] [review]
gtkrevealer: support minimum size of child

GtkRevealer always allocates the natural size of the child so the
bin_window can take care of the animation with the full allocation of
the child.

However when GtkRevealer allocates the child doesn't take into
account the minimum size of the child. On the other hand it does take
into account the minimum size of the child when reporting the preferred
size to the parent of the GtkRevealer.
This behaviour clips the child of the GtkRevealer if the parent
allocates less than the natural size.

To fix this inconsistency, the patch makes the child adapt the
allocation of the GtkRevealer as long as it's not under the minimum
size of the child.

Note that it no longer takes into account the animation type to report
the child size. I don't think that part is necessary.
Comment 2 Timm Bäder 2016-06-16 08:37:02 UTC 
Does that patch break the revealer sizing test?
Comment 3 Carlos Soriano 2016-06-16 12:32:44 UTC 
(In reply to Timm Bäder from comment #2)
> Does that patch break the revealer sizing test?

No
Comment 4 Matthias Clasen 2018-02-10 05:05:23 UTC 
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 5 Carlos Soriano 2018-02-10 08:59:00 UTC 
This patch is still relevant for 3.22 at least
Comment 6 GNOME Infrastructure Team 2018-05-02 17:13:38 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/635.