After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767664 - Not working with python3: AttributeError: 'dict' object has no attribute 'has_key'
Not working with python3: AttributeError: 'dict' object has no attribute 'has...
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
0.4.x
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-14 19:51 UTC by Laurent Bigonville
Modified: 2016-07-09 07:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add missing python3 compatibile code (4.70 KB, patch)
2016-06-16 06:05 UTC, Parag AN 		accepted-commit_now Details | Review

Description Laurent Bigonville 2016-06-14 19:51:20 UTC 
Hi,

With python3, I get the following backtrace when starting caribou-preferences:

Traceback (most recent call last):

+ Trace 236352

  • File "<string>", line 9 in <module>
  • File "/usr/lib/python3/dist-packages/caribou/settings/setting_types.py", line 65 in __call__ 
    self._manager =  SettingsManager(self)
  • File "/usr/lib/python3/dist-packages/caribou/settings/settings_manager.py", line 11 in __init__ 
    self._map_settings(self.groups)
  • File "/usr/lib/python3/dist-packages/caribou/settings/settings_manager.py", line 22 in _map_settings 
    if self._settings_map.has_key(setting.name):
AttributeError: 'dict' object has no attribute 'has_key' 






Comment 1


Parag AN





          2016-06-15 05:55:49 UTC
        



yes the source code is not fully python3 compatible yet in upstream. Let me submit the patch for it here.






Comment 2


Parag AN





          2016-06-16 06:05:33 UTC
        



Created attachment 329890 [details] [review]
Add missing python3 compatibile code






Comment 3


Daiki Ueno





          2016-06-16 09:17:17 UTC
        



Review of attachment 329890 [details] [review]:

Sure






Comment 4


Laurent Bigonville





          2016-06-27 11:48:30 UTC
        



Can somebody merge this patch in git?






Comment 5


Parag AN





          2016-06-27 12:39:15 UTC
        



I believe commit c2bb701afab3c41cedf212ab4107e09584a6dabf fixes issue reported here.






Comment 6


Parag AN





          2016-07-09 07:39:39 UTC
        



Wish I would have given permission to close this bug.