GNOME Bugzilla – Bug 767646
UI tweaks towards new panel design
Last modified: 2018-01-18 01:56:36 UTC
The Sharing panel doesn't require big structural changes such as the Printers, Keyboard, Mouse, and UserAccounts panels -- but there are UI differences between the current implementation and the up-to-date mockups available at https://wiki.gnome.org/Design/SystemSettings/Sharing The following patches address these UI tweaks.
Created attachment 329778 [details] [review] sharing: properly resize listbox rows
Created attachment 329779 [details] [review] sharing: update media sharing dialog description To match the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Created attachment 329780 [details] [review] sharing: update Screen Sharing dialog description To match the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Created attachment 329781 [details] [review] sharing: use a checkbutton in Screen Sharing dialog According to the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing We should use a checkbutton instead of a switch for the "Allow connections to control the screen" option. Also, this commit changes this option label accordingly.
Created attachment 329782 [details] [review] sharing: move Remote Login switch to headerbar According to the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Created attachment 329783 [details] [review] sharing: update Remote Login dialog description To match the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Created attachment 329784 [details] [review] sharing: drop the "Personal" from "Personal File Sharing" According to the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Review of attachment 329779 [details] [review]: Sure. Please upper-case the beginning of the sentence after "sharing: " (and for all the other patches as well).
Review of attachment 329780 [details] [review]: Quotes around the dialogue name in the commit message, and upper-case at the start of the sentence.
Review of attachment 329781 [details] [review]: Same as before regarding the commit subject.
Review of attachment 329782 [details] [review]: Sure.
Review of attachment 329783 [details] [review]: Indentation is utterly broken here. ::: panels/sharing/cc-sharing-panel.c @@ +683,3 @@ + text = g_strdup_printf (_("When remote login is enabled, remote users can connect using the Secure Shell command:\n<a href=\"ssh %s\">ssh %s</a>"), hostname, hostname); + else if (label == WID ("screen-sharing-label")) + text = g_strdup_printf (_("Screen sharing allows remote users to view or control your screen by connecting to <a href=\"vnc://%s\">vnc://%s</a>"), hostname, hostname); Why did the indentation change on this unrelated line? ::: panels/sharing/sharing.ui @@ +410,3 @@ <property name="can_focus">False</property> <property name="xalign">0</property> + <property name="label">When remote login is enabled, remote users can connect using the Shell command: Do this in a separate patch from getting the short name from Avahi.
Review of attachment 329784 [details] [review]: ::: panels/sharing/sharing.ui @@ -72,3 @@ <property name="halign">start</property> <property name="hexpand">True</property> - <property translatable="yes" name="label">_Personal File Sharing</property> We lost a mnemonic here, need to replace it.
Attachment 329779 [details] pushed as 4d001f7 - sharing: Update "Media Sharing" dialog description Attachment 329780 [details] pushed as 612ac49 - sharing: Update "Screen Sharing" dialog description Attachment 329781 [details] pushed as 8b68961 - sharing: Use a checkbutton in the "Screen Sharing" dialog Attachment 329782 [details] pushed as 8e414f8 - sharing: Move "Remote Login" switch to headerbar
Created attachment 329798 [details] [review] sharing: Drop the "Personal" from "Personal File Sharing" According to the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Review of attachment 329798 [details] [review]: ::: panels/sharing/sharing.ui @@ +72,3 @@ <property name="halign">start</property> <property name="hexpand">True</property> + <property translatable="yes" name="label">File Sharing</property> The mnemonic is on the label, not on the headerbar.
Created attachment 329849 [details] [review] sharing: Drop the "Personal" from "Personal File Sharing" According to the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Created attachment 329850 [details] [review] sharing: Update "Remote Login" dialog description To match the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Created attachment 329851 [details] [review] sharing: Update label text for "Remote Login" This label is constructed after the avahi hostname discovery. This change matches the new designs at https://wiki.gnome.org/Design/SystemSettings/Sharing
Review of attachment 329849 [details] [review]: Looks good.
Review of attachment 329850 [details] [review]: Yep.
Review of attachment 329851 [details] [review]: > This label is constructed after the avahi hostname discovery. It's not, yet. This can be merged into the previous patch, as you're changing both the placeholder string in the .ui file, and the generated string.
Attachment 329849 [details] pushed as f3b7c16 - sharing: Drop the "Personal" from "Personal File Sharing" Attachment 329850 [details] pushed as da1d8f0 - sharing: Update "Remote Login" dialog description
Review of attachment 329778 [details] [review]: This actually looks good, and applies on top of master.
Attachment 329778 [details] pushed as afbdddc - sharing: properly resize listbox rows With that, this bug can be finally closed. Rest in peace.