GNOME Bugzilla – Bug 767629
Remove geocode-enum-types.xml to fix out-of-source gtk-doc build
Last modified: 2016-09-27 17:52:05 UTC
docs/geocode-glib-docs.xml lists geocode-enum-types.xml, but geocode-enum-types.xml is not generated when doing out-of-source build. As it doesn't provide useful information to users, I think it is better to remove it than fixing the build.
Created attachment 329749 [details] [review] build: Fix gtk-doc build when builddir != srcdir The generated geocode-enum-types.xml is not useful and can be removed.
Does someone have time to review this trivial patch? It has stayed in bugzilla for 1 month.
Review of attachment 329749 [details] [review]: Sorry for delay! And thanks for patch!
Attachment 329749 [details] pushed as a646012 - build: Fix gtk-doc build when builddir != srcdir
This seem to have broken distcheck: $ cat ./geocode-glib-3.22.0/_build/sub/docs/gtkdoc-check.log Running suite(s): gtk-doc-geocode-glib /home/jonas/jhbuild/checkout/geocode-glib/geocode-glib-3.22.0/_build/sub/docs/geocode-glib-docs.xml doesn't appear to include "xml/geocode-enum-types.xml" 75.0%: Checks 4, Failures: 1 FAIL gtkdoc-check.test (exit status: 1)
I don't know how to reproduce the error message with 'gmake distcheck'. After disabling several failing tests in test-gcglib.c, I saw failure when running gtkdoc-check.test but with different message: $ cat geocode-glib-3.20.1/_build/sub/docs/gtkdoc-check.log Running suite(s): gtk-doc-geocode-glib geocode-glib-3.20.1/_build/sub/docs/geocode-glib-unused.txt:1:E: 10 unused documentation entries 75.0%: Checks 4, Failures: 1 FAIL gtkdoc-check.test (exit status: 1)