After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767626 - Fix the build when srcdir != builddir
Fix the build when srcdir != builddir
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-14 02:21 UTC by Ting-Wei Lan
Modified: 2016-06-17 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Allow building in non-srcdir (clutter-gst-2.0 branch) (2.73 KB, patch)
2016-06-14 02:22 UTC, Ting-Wei Lan 		none Details | Review
build: Allow building in non-srcdir (clutter-gst-3.0 branch) (1.95 KB, patch)
2016-06-14 02:22 UTC, Ting-Wei Lan 		committed Details | Review
build: Allow building in non-srcdir (clutter-gst-2.0 branch) (5.13 KB, patch)
2016-06-16 17:44 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-06-14 02:21:32 UTC 
Recent updates make JHBuild default to builddir != srcdir, but clutter-gst doesn't seems to support it. Please see the attached patches for both clutter-gst-2.0 and clutter-gst-3.0 branches.
Comment 1 Ting-Wei Lan 2016-06-14 02:22:38 UTC 
Created attachment 329742 [details] [review]
build: Allow building in non-srcdir (clutter-gst-2.0 branch)
Comment 2 Ting-Wei Lan 2016-06-14 02:22:57 UTC 
Created attachment 329743 [details] [review]
build: Allow building in non-srcdir (clutter-gst-3.0 branch)
Comment 3 Emmanuele Bassi (:ebassi) 2016-06-14 10:06:42 UTC 
Strictly speaking, all those $(srcdir) should go away, and the build should use the appropriate include paths. I did try fixing that when I updated various modules for the jhbuild change, but it ended up cascading into a bunch of build fixes and I had to punt for lack of time.
Comment 4 Ting-Wei Lan 2016-06-16 17:44:04 UTC 
Created attachment 329904 [details] [review]
build: Allow building in non-srcdir (clutter-gst-2.0 branch)

Yes, I agree $(srcdir) should not appear in _SOURCES, but existing Makefiles
do use these variables in different ways and cause $(srcdir) and $(builddir)
to be required. This patch removes all $(srcdir) and $(builddir) in _SOURCES,
and add them with addprefix when required.
Comment 5 Lionel Landwerlin 2016-06-17 18:48:56 UTC 
Review of attachment 329743 [details] [review]:

Pushed to 3.0 branch.
Comment 6 Lionel Landwerlin 2016-06-17 18:49:34 UTC 
Review of attachment 329904 [details] [review]:

Pushed to 2.0 branch.
Comment 7 Lionel Landwerlin 2016-06-17 18:50:03 UTC 
Pushed, thanks a lot!