After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767622 - Add borderWidth setting
Add borderWidth setting
Status: RESOLVED OBSOLETE
Product: gnome-terminal
Classification: Core
Component: general
3.20.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on: 774710
Blocks:
 
 
Reported: 2016-06-13 21:38 UTC by Simon Nagl
Modified: 2021-06-10 21:07 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Simon Nagl 2016-06-13 21:38:06 UTC
Add a border around the terminal output. The width should be controllable over a profile setting.

xterm has a setting doing this called borderWidth (https://wiki.archlinux.org/index.php/Xterm#Remove_black_border)

This would be useful when using with a theme/window manager with minimal window borders.
Comment 1 Egmont Koblinger 2016-06-13 21:43:23 UTC
This is already available (although as a global and not a per-profile setting).

Place something like this in ~/.config/gtk-3.0/gtk.css:

VteTerminal, vte-terminal {
    padding: 5px;
}

You can use up to 4 space separated values (top, right, bottom, left), just like in HTML CSS.
Comment 2 Egmont Koblinger 2016-06-13 21:50:09 UTC
Expect problems to arise if you set it to 0px. E.g. see bug 756024. Also auto-scrolling when dragging the mouse might not work (I'm not sure). And there's no room for the outlined rectangle cursor, or the rightmost pixel column to overflow (e.g. fake bold, or antialias) which happens much more frequently than you'd think so it could look like it's a bit chopped.

So you should have at least 1px of padding both for functional and aesthetic reasons.
Comment 3 Egmont Koblinger 2016-06-13 21:55:59 UTC
As for making it per-profile:

I really wouldn't want to make a VTE API call for the padding and then store the desired padding in some hidden gsetting (and repeat the same for cursor-aspect-ratio and all others).

I'm wondering however whether we should introduce an API to set an additional class for the VTE widget, and make g-t automatically apply a classname derived from the profile name (punctuation chars etc. removed). This way you could rely on the profile name in the CSS selectors.

@ChPe what do you think?
Comment 4 Simon Nagl 2016-06-13 22:26:48 UTC
(In reply to Egmont Koblinger from comment #1)
> Place something like this in ~/.config/gtk-3.0/gtk.css:
> 
> VteTerminal, vte-terminal {
>     padding: 5px;
> }

Wow! Thank you for the fast reply. This fits my needs.

 (In reply to Egmont Koblinger from comment #2)
> So you should have at least 1px of padding both for functional and aesthetic
> reasons.

Thank you for that advice. You can close this if you want. Anyways making it available in the settings would increase usability. I understand if you argue this is a minor setting most gnome users do not need.

A per profile setting would be great. However my major issue is already there. Thank you for helping!
Comment 5 Christian Persch 2016-08-01 17:02:26 UTC
(In reply to Egmont Koblinger from comment #3)
> @ChPe what do you think?

I wouldn't be opposed to that :-)
Comment 6 GNOME Infrastructure Team 2021-06-10 21:07:44 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/7676.