After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767620 - Build bijiben in non-srcdir
Build bijiben in non-srcdir
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-13 19:35 UTC by Ting-Wei Lan
Modified: 2017-03-25 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove a vim swap file (2.46 KB, patch)
2016-06-13 19:36 UTC, Ting-Wei Lan 		none Details | Review
build: Allow build in non-srcdir (1.04 KB, patch)
2016-06-13 19:36 UTC, Ting-Wei Lan 		accepted-commit_now Details | Review

Description Ting-Wei Lan 2016-06-13 19:35:18 UTC 
Recent updates make JHBuild default to builddir != srcdir, but bijiben doesn't seems to support it because src/libbiji/provider/biji-provider.c expects biji-marshalers.h to be available in srcdir.
Comment 1 Ting-Wei Lan 2016-06-13 19:36:18 UTC 
Created attachment 329715 [details] [review]
Remove a vim swap file
Comment 2 Ting-Wei Lan 2016-06-13 19:36:46 UTC 
Created attachment 329716 [details] [review]
build: Allow build in non-srcdir
Comment 3 Ting-Wei Lan 2016-07-16 15:53:21 UTC 
Does someone have time to review these trivial patches? They have stayed in bugzilla for 1 month.
Comment 4 Ting-Wei Lan 2016-08-16 07:35:57 UTC 
As GNOME 3.22 is going to be released, can these trivial patches be reviewed soon?
Comment 5 Isaque Galdino 2017-03-01 04:19:31 UTC 
Review of attachment 329716 [details] [review]:

Next time, please be more verbose in the patch description.

Try to follow these commit guidelines: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines
Comment 6 Isaque Galdino 2017-03-01 04:28:19 UTC 
Oh, and thanks for your patch :)

BTW, I couldn't apply your vim removal swap files removal.
Comment 7 Ting-Wei Lan 2017-03-25 15:33:46 UTC 
(In reply to Isaque Galdino from comment #6)
> Oh, and thanks for your patch :)
> 
> BTW, I couldn't apply your vim removal swap files removal.

src/libbiji/.Makefile.am.swp does exist in the source tree. Did you apply it with 'git am'?