After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767487 - Move perspective switching into the header bar
Move perspective switching into the header bar
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-10 10:01 UTC by Allan Day
Modified: 2016-06-28 05:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Allan Day 2016-06-10 10:01:30 UTC
The current perspective switcher is in a vertical bar on the left side of the window. This isn't a very good use of screen space, and leaves a lot of dead pixels. More importantly, though, it feels tacked on, and doesn't fit with the hierarchy of the window (which flows from top to bottom, with the header bar as the sovereign element).

It would therefore be better to have perspective switching UI located in the header bar.

The latest mockups recommend using a minimal drop down in the top left corner (the top of the visual hierarchy):

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/builder/builder-header-bar-wires.png

The widget is deliberately minimal, in order to give space for other elements and keep the header bar visually balanced.
Comment 1 Christian Hergert 2016-06-23 18:31:14 UTC
I've been working on a bunch of the design improvements on wip/chergert/headerbar.

One thing that is not clear is how we inform the user they can click on (what I am calling) the OmniBar in the center of the headerbar. At the moment, I've just chosen to change the cursor when hovered to "pointer" (which is what we use for hyperlinks).

Thoughts? Alternate suggestions?
Comment 2 Allan Day 2016-06-24 15:47:22 UTC
(In reply to Christian Hergert from comment #1)
...
> One thing that is not clear is how we inform the user they can click on
> (what I am calling) the OmniBar in the center of the headerbar. At the
> moment, I've just chosen to change the cursor when hovered to "pointer"
> (which is what we use for hyperlinks).
> 
> Thoughts? Alternate suggestions?

I wouldn't change the pointer. Instead would change appearance of the button when it's hovered, with some kind of highlight.
Comment 3 Christian Hergert 2016-06-25 22:56:24 UTC
Most of this is fixed on the wip/chergert/headerbar branch. Some of the changes are intrusive enough that it requires me implementing some of the other designs as part of this work.

Hopefully will have things merged soon.

A couple more questions arise though.

Should we get rid of the Build Output panel at the bottom, and the panel on the right?

I think we can get rid of both of those if we:

 1) add errors/warnings info to the omnibar popover
    (thoughts? design ideas?)
 2) When clicking "View Output" we show the entire build
    output as if it were a file in the editor, so you get
    a large area to view the output.
Comment 4 Christian Hergert 2016-06-25 22:57:55 UTC
We can, at least, turn the right side build panel into a list of errors/warnings only, since the "current build configuration" would be duplicated.

Although, we also need to come up with a way to give access to clean/rebuild options in either the popover or next to the Build button in the omnibar.
Comment 5 Allan Day 2016-06-27 14:17:54 UTC
(In reply to Christian Hergert from comment #3)
> Most of this is fixed on the wip/chergert/headerbar branch. Some of the
> changes are intrusive enough that it requires me implementing some of the
> other designs as part of this work.
> 
> Hopefully will have things merged soon.
> 
> A couple more questions arise though.
> 
> Should we get rid of the Build Output panel at the bottom, and the panel on
> the right?
> 
> I think we can get rid of both of those if we:
> 
>  1) add errors/warnings info to the omnibar popover
>     (thoughts? design ideas?)

I'd be happy to look into that and it should probably be possible. Will need to get some more details about the errors/warnings and how they are used - let's talk about it.

>  2) When clicking "View Output" we show the entire build
>     output as if it were a file in the editor, so you get
>     a large area to view the output.

That sounds good to me.
Comment 6 Christian Hergert 2016-06-28 05:26:08 UTC
This has been merged to master.

The primary variation I have at the moment that we should look into is my use of build/rebuild/clean buttons in the popover (they match the styling from messagedialog).

Also, we still have the build panels, but no longer does the right panel have build buttons/configuration selection. The "View Output" button simply focuses the bottom panel after ensuring it is visible.