After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767446 - Unparented context menu when right clicking on navigation buttons
Unparented context menu when right clicking on navigation buttons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Main Toolbar
3.20.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: WaylandRelated
 
 
Reported: 2016-06-09 11:55 UTC by Michael Catanzaro
Modified: 2016-06-09 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] toolbar: Attach menu to the toplevel window (913 bytes, patch)
2016-06-09 12:52 UTC, Olivier Fourdan
committed Details | Review

Description Michael Catanzaro 2016-06-09 11:55:08 UTC
Right click on the forward or back icon in the top-left of the screen. At least when running under Wayland, the context menu appears waaay outside the nautilus window, on the other side of the desktop, instead of under the mouse cursor.
Comment 1 Olivier Fourdan 2016-06-09 12:50:31 UTC
Nautilus logs the following message when invoking the menu:

Gdk-Message: Window 0x562adfbb2cf0 is a temporary window without parent, application will not be able to position it on screen.
Comment 2 Olivier Fourdan 2016-06-09 12:52:05 UTC
Created attachment 329461 [details] [review]
[PATCH] toolbar: Attach menu to the toplevel window

Attach menu to the toplevel window, so that the menu doesn't show at random places under Wayland which expects all subsurfaces to have a parent surface.
Comment 3 Carlos Soriano 2016-06-09 13:25:14 UTC
Review of attachment 329461 [details] [review]:

Looks good. Is that expected to be done in context menus as well?
Comment 4 Olivier Fourdan 2016-06-09 13:40:10 UTC
(In reply to Carlos Soriano from comment #3)
> Looks good. Is that expected to be done in context menus as well?

nautilus_pop_up_context_menu() does the gtk_menu_attach_to_widget() already so no need, it works.
Comment 5 Olivier Fourdan 2016-06-09 13:41:49 UTC
You'd want the patch to be pushed in gnome-3-20 as well, or master only and you'll do the cherry-pick next time you release a 3.20 update?
Comment 6 Olivier Fourdan 2016-06-09 13:44:06 UTC
Comment on attachment 329461 [details] [review]
[PATCH] toolbar: Attach menu to the toplevel window

attachment 329461 [details] [review] has been pushed in master as commit 8994827 - toolbar: Attach menu to the toplevel window
Comment 7 Carlos Soriano 2016-06-09 13:53:12 UTC
Oh right, it already does it. I was unaware of this tbh...

yeah push to 3.20 too please :)
Comment 8 Olivier Fourdan 2016-06-09 14:14:47 UTC
attachment 329461 [details] [review] [review] has been pushed in branch gnome-3-20 as commit f84d431 - toolbar: Attach menu to the toplevel window