After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767401 - Don't use deprecated GoaProviderGroup API and add a Calendar group
Don't use deprecated GoaProviderGroup API and add a Calendar group
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
git master
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
Depends on:
Blocks: 720519
 
 
Reported: 2016-06-08 15:24 UTC by Debarshi Ray
Modified: 2016-06-09 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
online-accounts: Don't use deprecated GoaProviderGroup API (3.15 KB, patch)
2016-06-08 15:27 UTC, Debarshi Ray 		committed Details | Review
online-accounts: Add a Calendar group (2.24 KB, patch)
2016-06-08 15:27 UTC, Debarshi Ray 		committed Details | Review
Screenshot of Calendars and Contacts (without Chat) (183.73 KB, image/png)
2016-06-08 15:29 UTC, Debarshi Ray 		  Details

Description Debarshi Ray 2016-06-08 15:24:23 UTC 
There are patches floating around (bug 720519) that add separate CalDAV and CardDAV providers to gnome-online-accounts. Therefore, it is a good time to add a separate Calendar group. As always, if the provider is absent the group will be hidden from the UI.

Take this opportunity to stop using the deprecated GoaProviderGroup API.
Comment 1 Debarshi Ray 2016-06-08 15:27:18 UTC 
Created attachment 329397 [details] [review]
online-accounts: Don't use deprecated GoaProviderGroup API
Comment 2 Debarshi Ray 2016-06-08 15:27:42 UTC 
Created attachment 329400 [details] [review]
online-accounts: Add a Calendar group
Comment 3 Debarshi Ray 2016-06-08 15:29:52 UTC 
Created attachment 329401 [details]
Screenshot of Calendars and Contacts (without Chat)
Comment 4 Bastien Nocera 2016-06-09 11:39:53 UTC 
Review of attachment 329397 [details] [review]:

Sure.

Don't forget to bump the goa requires in configure.ac if needed.
Comment 5 Bastien Nocera 2016-06-09 11:41:20 UTC 
Review of attachment 329400 [details] [review]:

Sure.
Comment 6 Debarshi Ray 2016-06-09 13:33:53 UTC 
Thanks for the reviews, Bastien.

(In reply to Bastien Nocera from comment #4)
> Don't forget to bump the goa requires in configure.ac if needed.

The new API showed up in 3.10 and we already require 3.15, so it should be fine.
Comment 7 Debarshi Ray 2016-06-09 13:54:17 UTC 
Comment on attachment 329400 [details] [review]
online-accounts: Add a Calendar group

Pushed to master.