GNOME Bugzilla – Bug 767400
Unclarity whether "When" search filter means "around that date" or "up to that date"
Last modified: 2016-11-03 11:18:52 UTC
Created attachment 329395 [details] the two labels "When" and "4 weeks ago" leads to a misinterpretation in the range. This is related to applying the time search filter to a search. In the attached screenshot I read "When? 4 weeks ago" while in fact, what is meant is "When? Since 4 weeks ago". It would be nice if the label "4 weeks ago" was modified to include "Since".
Created attachment 336936 [details] [review] Apply time search filter to a search
Review of attachment 336936 [details] [review]: Hey Neha, thanks for the patch! The strings are wrong though: ::: src/nautilus-ui-utilities.c @@ +402,3 @@ { /* weeks */ + return ngettext ("Since Last week", "Since %d weeks ago", days / 7); you have typos here, you do "Since Last"... which is two caps. It should be just the first character of the sentence. Same for all the other cases.
Created attachment 336947 [details] [review] Apply time search filter to a search Updated all the changes
Review of attachment 336947 [details] [review]: This patch is a patch above the other patch. This is not how we work, but rather making one single good patch. Look at https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Follow_Up_on_the_Feedback
Created attachment 336955 [details] [review] Apply time search filter to a search Label is modified by including "Since"
Review of attachment 336955 [details] [review]: The code looks good now! Thanks! However the commit message it's not correct. Read https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines to know how to write a correct commit message.
Created attachment 336976 [details] [review] Apply time search filter to a search In commit we changed the label by simply adding "Since" The problem is that in search filter there is a misinterpretation because of two different label that is "When" and "4 weeks ago". Which is not clear for user that whether "When" represent to "around that date" or "up to that date". To fix this issue we simply add "Since" before time period inside file nautilus-ui-utilities.
Review of attachment 336976 [details] [review]: The commit message title is missing the file you are touching. Also the title is slightly confusing. How about: "ui-utilities: clarify search popover dates"
Created attachment 336986 [details] [review] ui-utilities: Apply time search filter to a search In commit we changed the label by simply adding "Since" The problem is that in search filter there is a misinterpretation because of two different label that is "When" and "4 weeks ago". Which is not clear for user that whether "When" represent to "around that date" or "up to that date". To fix this issue we simply add "Since" before time period inside file nautilus-ui-utilities.
Review of attachment 336986 [details] [review]: As pointed out before, the title of the commit message is not clear enough. I proposed "ui-utilities: clarify search popover dates", but you can come with something different and we can discuss it if you want.
Created attachment 336990 [details] [review] ui-utilities: clarify search popover dates In commit we changed the label by simply adding "Since" The problem is that in search filter there is a misinterpretation because of two different label that is "When" and "4 weeks ago". Which is not clear for user that whether "When" represent to "around that date" or "up to that date". To fix this issue we simply add "Since" before time period inside file nautilus-ui-utilities.
Review of attachment 336990 [details] [review]: I just realized this puts the "Since" also in the list box when selecting a date range... Instead it should be only in the resulting label, because if not it's too noisy and repeats the "since" label of the tittle. For that you will need to add some boolean to get_text_for_date_range to indicate you want the "since" word too, and also add this boolean to get_text_for_days_ago for the same purpose. Sorry I didn't notice this before.
Created attachment 338966 [details] [review] ui-utilities: clarify date label Date label does not point out that nautilus searches for files created after that date. In order to fix this, prepend "Since" to the date label.
Created attachment 338972 [details] [review] ui-utilities: clarify date label Date label does not point out that nautilus searches for files created after that date. In order to fix this, prepend "Since" to the date label.
Created attachment 338982 [details] [review] ui-utilities: clarify date label Date label does not point out that nautilus searches for files modified or used after that date. In order to fix this, prepend "Since" to the date label.
Created attachment 338983 [details] [review] ui-utilities: clarify date label Date label does not point out that nautilus searches for files modified or used after that date. In order to fix this, prepend "Since" to the date label.
Created attachment 338984 [details] [review] ui-utilities: clarify date label Date label does not point out that nautilus searches for files modified or used after that date. In order to fix this, prepend "Since" to the date label.
Review of attachment 338984 [details] [review]: LGTM, thanks!
Review of attachment 338984 [details] [review]: Looks good, thanks!!
Attachment 338984 [details] pushed as 01476a1 - ui-utilities: clarify date label