GNOME Bugzilla – Bug 767394
Migrate GtkTable to GtkGrid and add CSS selectors
Last modified: 2016-10-11 07:01:24 UTC
Created attachment 329382 [details] [review] Patch - GtkTable->GtkGrid and add some CSS classes GtkTable has been deprecated for a while and has been replaced with GtkGrid. This change: * reduces the amount of warnings in Glade * allows for easier design changes (e.g. changing a bit marker's color now only needs one extra line in calculator.css) * Which in its own makes it easier to solve other bugs such as bug 756920, by allowing extra/easier styling. If you want, I can continue migrating code.
Created attachment 329572 [details] [review] Added extra CSS classes Also added CSS classes for * numeric buttons (0..F) * the numeric point button * the fx-button
Review of attachment 329382 [details] [review]: Looks fine, only buttons in Financial mode do not have any vertical padding, and are placed edge-by-edge, this should be fixed.
Created attachment 335693 [details] Screenshot of financial mode See a screenshot with Calculator 3.20 (left) and Calculator master with the patch applied (right). You can see that the buttons are touching their vertical neighbours.
Created attachment 335694 [details] [review] Patch - Fixed row-spacing in buttons-financial.ui Whoops, good catch! Should be fixed with this trivial patch.
Ok, with this it works fine. I would say we should go with these patches after the stable release is out.
Yeah, no freeze exception for this. Thanks for helping out with Calculator, both of you!
The patches do not apply due to some recent styling changes from commit [1], could you please update the problematic patch? It would help this happen after branching gnome-3-22, I think most maintainers do that after 3.22.1 is out. [1] https://git.gnome.org/browse/gnome-calculator/commit/?id=bad0f883d6c086d90ca2e07991dbe2d76de9aa24
@Niels De Graef: do you have the time to update the patches this week, to get the changes in master early in the cycle? If not, just let us know, and we'll do our best to update the patches and include them, if possible.
Created attachment 336893 [details] [review] Patch - GtkTable->GtkGrid and add some CSS classes (applicable to master) Reworked patch. Been a bit busy since the academic year started again, but reworking a patch shouldn't be a problem. :)
Created attachment 336894 [details] [review] Patch - Added extra CSS classes (applicable to master)
Thanks for the contribution, gnome-3-22 is branched, your fixes are on master now, due to be released with the next development version.