After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767372 - missing sysdep: desktop-file-validate (desktop-file-utils)
missing sysdep: desktop-file-validate (desktop-file-utils)
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2016-06-07 18:26 UTC by Simon McVittie
Modified: 2016-08-23 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
3.22: gtk+ should suggest desktop-file-utils (1.17 KB, patch)
2016-08-23 11:57 UTC, Michael Catanzaro 		committed Details | Review

Description Simon McVittie 2016-06-07 18:26:32 UTC 
"jhbuild sysdeps" doesn't check that I have desktop-file-validate, which is needed for at least gnome-terminal.
Comment 1 Michael Catanzaro 2016-08-23 11:48:01 UTC 
We have it in sysdeps, but nothing depends on it. I think a fake dependency via gtk+ is appropriate here, that way we don't have to worry about adding it to a bunch of different applications.
Comment 2 Michael Catanzaro 2016-08-23 11:57:21 UTC 
The following fix has been pushed:
54bb28e 3.22: gtk+ should suggest desktop-file-utils
Comment 3 Michael Catanzaro 2016-08-23 11:57:25 UTC 
Created attachment 333999 [details] [review]
3.22: gtk+ should suggest desktop-file-utils

Many GTK+ apps depend on desktop-file-utils, but we don't know how many
and none currently have the dependency specified. Since it's a sysdep,
we can just add it to gtk+ and be done with it. This fixes the problem
for all except brave users who disable suggests; such users are expected
to be able to handle breakage caused by that.