GNOME Bugzilla – Bug 767368
unnecessary dependency on uuidgen which isn't checked for by jhbuild.
Last modified: 2016-06-07 18:09:13 UTC
gjs requires the uuidgen executable, which doesn't seem to be checked for by jhbuild sysdeps. In particular, gjs will fail to build in this setup: * Debian testing/unstable in a virtual machine * Install build-essential plus everything requested by `jhbuild sysdeps` * uuid-dev (development files for libuuid) is present * uuid-runtime (uuidgen and uuidd) is not present Looking at how gjs uses uuidgen, it seems dbus-uuidgen would be entirely sufficient - all it wants is an unpredictable string, it doesn't care about the specific form of that string. dbus-uuidgen is part of a package that the D-Bus tests will need anyway, since it's typically packaged alongside dbus-daemon. (That's why I'm filing this as a gjs bug, and not a jhbuild moduleset bug.) Preparing a patch.
Created attachment 329317 [details] [review] tests: use dbus-uuidgen instead of uuidgen uuidgen is not always installed, even if libuuid is: for example, in Debian derivatives it's packaged in uuid-runtime alongside uuidd, a daemon that is in practice nearly always unnecessary. The only use of uuidgen is in a script that already requires dbus-daemon, and all it needs is a random hex string, so dbus-uuidgen is fine.
Review of attachment 329317 [details] [review]: LGTM, thanks.
Comment on attachment 329317 [details] [review] tests: use dbus-uuidgen instead of uuidgen 01f7ed7
Fixed in git for 1.45.4