GNOME Bugzilla – Bug 767339
libselinux should be a sysdep for nautilus
Last modified: 2016-08-23 13:40:54 UTC
Nautilus has a mandatory check for libselinux.pc (except when --disable-selinux is explicitly used, as on non-Linux), so libselinux should maybe be a sysdep. (However, it also seems wrong that Nautilus hard-requires libselinux unless specifically told not to - I would expect it to be more like the SELinux support in dbus, where the default is to auto-detect, but distributions can forcibly enable or disable to avoid auto-detection. I'll open a Nautilus bug for that.)
I don't like automagic dependencies. In the case of nautilus it probably doesn't matter much, since all distros probably already have nautilus configured properly, but in general I think it's a terrible idea for features to be added or disabled because a packager has forgotten a BuildRequires in a spec/control file. So I wouldn't recommend changing nautilus here. As for jhbuild, I think it's OK to build with --disable-selinux, but I guess all distros at least have libselinux available, so it's probably best to just add the missing sysdep.
The following fix has been pushed: 0627874 3.22: nautilus depends on libselinux
Created attachment 334000 [details] [review] 3.22: nautilus depends on libselinux
Sorry, I have to revert this as some distros doesnt have libselinux packages (like Arch)
OK, let's build with --disable-selinux then.
The following fix has been pushed: f93d8f6 3.22: Always build nautilus with --disable-selinux
Created attachment 334005 [details] [review] 3.22: Always build nautilus with --disable-selinux Apparently some Linux distros do not have libselinux at all.