After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767274 - Port PNG saver (png-save) to GIO
Port PNG saver (png-save) to GIO
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2016-06-05 21:09 UTC by Martin Blanchard
Modified: 2017-05-11 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
First attempt (8.05 KB, patch)
2016-06-05 21:25 UTC, Martin Blanchard 		none Details | Review
patch rebased on current master (8.06 KB, patch)
2017-05-11 12:48 UTC, Øyvind Kolås (pippin) 		none Details | Review

Description Martin Blanchard 2016-06-05 21:09:00 UTC 
Operation png-save should be ported to GIO (should use gegl_gio_open_output_stream()). More informations:

http://wiki.gimp.org/index.php/Hacking:Porting_file_plugins_to_GEGL_and_GIO
Comment 1 Martin Blanchard 2016-06-05 21:25:33 UTC 
Created attachment 329166 [details] [review]
First attempt
Comment 2 Øyvind Kolås (pippin) 2017-05-11 12:48:16 UTC 
Created attachment 351623 [details] [review]
patch rebased on current master

I've uploaded a patch rebased on master, multiple tests are failing by saving the wrong dimension pngs - seemingly to do with negative origins for passed buffers.
Comment 3 Øyvind Kolås (pippin) 2017-05-11 15:21:49 UTC 
commit 3dce6741b0e7b135f7cfd07869812c0d1dc5845b
Author: Øyvind Kolås <pippin@gimp.org>
Date:   Thu May 11 17:19:20 2017 +0200

    png-save: correctly handle region of interest

commit 7763be188d1cbd7bb286a5ce84825feaf15242a4
Author: Martin Blanchard <tchaik@gmx.com>
Date:   Sun Jun 5 23:22:03 2016 +0200

    png-save: port to GIO
    
    Make use of gegl_gio_open_output_stream() service. No more direct
    fopen() call for output.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=767274