After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767271 - Fix hardcoded `pkg-config` binary usage
Fix hardcoded `pkg-config` binary usage
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.25
Other Linux
: Normal normal
: ---
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-05 17:47 UTC by Marvin Schmidt
Modified: 2016-06-05 18:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use PKG_CONFIG variable instead of hardcoding the pkg-config binary (1.86 KB, patch)
2016-06-05 17:47 UTC, Marvin Schmidt 		committed Details | Review
depscan/fixxref/rebase: Don't hardcode pkg-config binary (1.93 KB, patch)
2016-06-05 18:17 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Marvin Schmidt 2016-06-05 17:47:26 UTC 
Created attachment 329160 [details] [review]
use PKG_CONFIG variable instead of hardcoding the pkg-config binary

gtkdoc-{depscan,fixxref,rebase} hardcode the use of `pkg-config` which is not necessarily the correct pkg-config binary for the targetted host architecture. PKG_PROG_PKG_CONFIG already tries to find a host-prefixed version of pkg-config and sets the PKG_CONFIG variable accordingly, so we can just use that to get the right pkg-config binary
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2016-06-05 18:15:19 UTC 
The following fixes have been pushed:
c7e7424 depscan/fixxref/rebase: Don't hardcode pkg-config binary
08e723a rebase: add tracing support
5ee4e11 scan: only copy new sections file if it changed
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2016-06-05 18:17:13 UTC 
The following fix has been pushed:
64d940b depscan/fixxref/rebase: Don't hardcode pkg-config binary
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2016-06-05 18:17:20 UTC 
Created attachment 329163 [details] [review]
depscan/fixxref/rebase: Don't hardcode pkg-config binary

`pkg-config` is not necessarily the correct pkg-config binary,
especially in cross-compilation scenarios. Use the pkg-config binary
that PKG_PROG_PKG_CONFIG (which looks for host-prefixed pkg-config)
found and defined in PKG_CONFIG
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2016-06-05 18:18:09 UTC 
Thanks!