Created attachment 329157 [details] [review]
preview: Rename to EvinceView

This makes it clearer that this view is type-specific, similarly to the
LOKView for LibreOffice.

The goal would be to push view (and type) specific queries into each view. For example, whether we can print, the default setup of the view widget, etc.

Created attachment 329159 [details] [review]
windowMode: Rename PREVIEW window mode to PREVIEW_EV

I can't find how to sort out the load-started/load-finished mechanism so that it's not as evince specific.

We might also want to have a genericview with a specific interface that the different views can implement.

(we managed to do a bit of cleanup when we added the lokview, but with the epub view, we'd get up to 3 views, and with similar requirements as the ev view, such as bookmarks, remembering the current progress, maybe printing)

Review of attachment 329157 [details] [review]:

Makes sense, thanks.

Review of attachment 329159 [details] [review]:

Yep

(In reply to Bastien Nocera from comment #4)
> I can't find how to sort out the load-started/load-finished mechanism so
> that it's not as evince specific.
> 
> We might also want to have a genericview with a specific interface that the
> different views can implement.

Yeah, IIRC the loader gives back an EvDocModel. I would need to take a look a bit more at the details of it, but a view abstraction would sounds good to me.
It would also give us the opportunity to deduplicate/cleanup the preview controls and toolbar code.

Attachment 329157 [details] pushed as 29c4a9f - preview: Rename to EvinceView
Attachment 329159 [details] pushed as e7b9159 - windowMode: Rename PREVIEW window mode to PREVIEW_EV