After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767267 - Add missing filename type annotations
Add missing filename type annotations
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-05 16:27 UTC by Christoph Reiter (lazka)
Modified: 2018-01-08 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add missing filename type annotations (2.86 KB, patch)
2016-06-05 16:27 UTC, Christoph Reiter (lazka)
none Details | Review
Add missing filename type annotations (5.75 KB, patch)
2018-01-05 13:22 UTC, Christoph Reiter (lazka)
committed Details | Review

Description Christoph Reiter (lazka) 2016-06-05 16:27:46 UTC
Created attachment 329155 [details] [review]
Add missing filename type annotations

I'm currently working on improving filename handling in PyGObject which depends on filenames being annotated as such. See bug 746564
Comment 1 Matthias Clasen 2016-08-02 18:59:21 UTC
I'm no longer committing binding api changes unless they have bee sufficiently vetted by language binding people. Can you get a second person to chime in here ?
Comment 2 Bastien Nocera 2016-12-19 17:47:54 UTC
Christoph, any updates?
Comment 3 Christoph Reiter (lazka) 2016-12-19 17:52:15 UTC
I've posted to the gi mailing list and IRC but did not get any feedback on these patches.
Comment 4 Christoph Reiter (lazka) 2017-03-30 09:40:18 UTC
There where quite a few filename annotation additions before 2.50 in glib and I don't think there was any fallout reported last cycle. Can this go in as well now?

https://git.gnome.org/browse/glib/log/?qt=grep&q=filename
Comment 5 Christoph Reiter (lazka) 2018-01-05 13:22:25 UTC
Created attachment 366378 [details] [review]
Add missing filename type annotations

Rebased on master and added annotations to a few more functions which I missed the first time.

I'd really like to see this in. We have recently moved to Python 3 which is more strict with text vs filenames and I've started to get error reports like this one https://sentry.io/share/issue/2d9327483ed745209d92eb00ff34e31b/ :(
Comment 6 Bastien Nocera 2018-01-08 15:02:25 UTC
Thanks for the patch!
Comment 7 Christoph Reiter (lazka) 2018-01-08 15:07:50 UTC
Thanks \o/