GNOME Bugzilla – Bug 767267
Add missing filename type annotations
Last modified: 2018-01-08 15:07:50 UTC
Created attachment 329155 [details] [review] Add missing filename type annotations I'm currently working on improving filename handling in PyGObject which depends on filenames being annotated as such. See bug 746564
I'm no longer committing binding api changes unless they have bee sufficiently vetted by language binding people. Can you get a second person to chime in here ?
Christoph, any updates?
I've posted to the gi mailing list and IRC but did not get any feedback on these patches.
There where quite a few filename annotation additions before 2.50 in glib and I don't think there was any fallout reported last cycle. Can this go in as well now? https://git.gnome.org/browse/glib/log/?qt=grep&q=filename
Created attachment 366378 [details] [review] Add missing filename type annotations Rebased on master and added annotations to a few more functions which I missed the first time. I'd really like to see this in. We have recently moved to Python 3 which is more strict with text vs filenames and I've started to get error reports like this one https://sentry.io/share/issue/2d9327483ed745209d92eb00ff34e31b/ :(
Thanks for the patch!
Thanks \o/