After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767253 - Fix continuous mode never being disabled
Fix continuous mode never being disabled
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
: 761827 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-06-04 18:36 UTC by Bastien Nocera
Modified: 2016-06-05 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
documents: Move comment to where it applies (961 bytes, patch)
2016-06-04 18:36 UTC, Bastien Nocera 		committed Details | Review
documents: Fix continuous mode never being disabled (935 bytes, patch)
2016-06-04 18:36 UTC, Bastien Nocera 		committed Details | Review
documents: Remove docModel argument for metadata (1.92 KB, patch)
2016-06-04 18:36 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-06-04 18:36:24 UTC 
and other fixes
Comment 1 Bastien Nocera 2016-06-04 18:36:28 UTC 
Created attachment 329132 [details] [review]
documents: Move comment to where it applies
Comment 2 Bastien Nocera 2016-06-04 18:36:34 UTC 
Created attachment 329133 [details] [review]
documents: Fix continuous mode never being disabled

A typo in commit de4139f2 made the call dependent on the
this._activeModel variable existing. Except that it's not called
activeModel but activeDocModel.
Comment 3 Bastien Nocera 2016-06-04 18:36:40 UTC 
Created attachment 329134 [details] [review]
documents: Remove docModel argument for metadata

A refactor that will be necessary when we want to use metadata without a
docModel (for EPub support for example).
Comment 4 Bastien Nocera 2016-06-05 12:58:03 UTC 
*** Bug 761827 has been marked as a duplicate of this bug. ***
Comment 5 Cosimo Cecchi 2016-06-05 14:29:08 UTC 
Review of attachment 329133 [details] [review]:

Whoops, good catch.
Comment 6 Cosimo Cecchi 2016-06-05 14:29:39 UTC 
Review of attachment 329134 [details] [review]:

Sure
Comment 7 Cosimo Cecchi 2016-06-05 14:29:51 UTC 
Review of attachment 329132 [details] [review]:

OK
Comment 8 Bastien Nocera 2016-06-05 15:11:41 UTC 
Attachment 329132 [details] pushed as 5bbc136 - documents: Move comment to where it applies
Attachment 329133 [details] pushed as 94badd5 - documents: Fix continuous mode never being disabled
Attachment 329134 [details] pushed as f155019 - documents: Remove docModel argument for metadata