After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767252 - documents: Don't offer to open in file-roller
documents: Don't offer to open in file-roller
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-04 18:35 UTC by Bastien Nocera
Modified: 2016-06-05 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
documents: Don't offer to open in file-roller (1.44 KB, patch)
2016-06-04 18:35 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-06-04 18:35:42 UTC 
.
Comment 1 Bastien Nocera 2016-06-04 18:35:47 UTC 
Created attachment 329131 [details] [review]
documents: Don't offer to open in file-roller

Don't offer to open CBR or CBZ files in file-roller, even if it is
listed as a recommended application.

file-roller has explicitely handled cbr and cbz files for a long while,
and despite our efforts to stop documents being opened as archives
(which worked correctly for EPubs and LibreOffice formats), we should
try and be more forceful.

See https://bugzilla.gnome.org/show_bug.cgi?id=767244
Comment 2 Cosimo Cecchi 2016-06-05 14:28:24 UTC 
Review of attachment 329131 [details] [review]:

Looks good to me.
Comment 3 Bastien Nocera 2016-06-05 15:11:26 UTC 
Attachment 329131 [details] pushed as 4d5256f - documents: Don't offer to open in file-roller