After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767220 - gnome-software crashed with SIGSEGV in strlen()
gnome-software crashed with SIGSEGV in strlen()
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-03 21:07 UTC by Cristian Aravena Romero
Modified: 2016-06-07 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Cristian Aravena Romero 2016-06-03 21:07:13 UTC 
Bug open in launchpad.net
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1588950

"Update and crash."


BackTrace:

+ Trace 236298

  • #0 strlen
    at ../sysdeps/x86_64/strlen.S line 106
  • #1 as_utils_search_token_valid
    at as-utils.c line 1302
  • #2 as_app_add_token_internal
    at as-app.c line 4434
  • #3 as_app_add_token
    at as-app.c line 4468
  • #4 as_app_create_token_cache_target
    at as-app.c line 4557
  • #5 as_app_create_token_cache
    at as-app.c line 4575
  • #6 as_app_search_matches
    at as-app.c line 4608
  • #7 as_app_search_matches_all
    at as-app.c line 4685
  • #8 gs_plugin_add_search_item
    at gs-plugin-appstream.c line 482
  • #9 gs_plugin_add_search
    at gs-plugin-appstream.c line 531
  • #10 gs_plugin_loader_search_thread_cb
    at gs-plugin-loader.c line 1507
  • #11 g_task_thread_pool_thread
    from /tmp/apport_sandbox_X_NPkc/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
  • #12 g_thread_pool_thread_proxy
    from /tmp/apport_sandbox_X_NPkc/lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #13 g_thread_proxy
    from /tmp/apport_sandbox_X_NPkc/lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #14 start_thread
    at pthread_create.c line 333
  • #15 clone
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 109 






Comment 1


Richard Hughes





          2016-06-07 10:44:37 UTC
        



commit 960a6d9d22d6f7756093ffdb5fa46c1b588991e3
Author: Richard Hughes <richard@hughsie.com>
Date:   Tue Jun 7 11:42:11 2016 +0100

    Never allow NULL to be added to AsApp string array
    
    This is going to make incorrect code produce a critical warning when adding
    invalid values, but that's better than segfaulting in other random parts of
    the library.
    
    Fixes the crash https://bugzilla.gnome.org/show_bug.cgi?id=767220 but we'll
    need to dig deeper working out what is calling as_app_add_pkgname() with NULL.

:100644 100644 87a2236... 0de4fc6... M  libappstream-glib/as-app.c