After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767207 - Build fixes
Build fixes
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-03 16:43 UTC by Bastien Nocera
Modified: 2016-06-06 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix autogen.sh for builddir != srcdir (788 bytes, patch)
2016-06-03 16:43 UTC, Bastien Nocera 		committed Details | Review
build: Fix -Wformat-y2k compilation errors (1.84 KB, patch)
2016-06-03 16:43 UTC, Bastien Nocera 		reviewed Details | Review
build: Fix -Wformat-nonliteral compilation errors (3.35 KB, patch)
2016-06-03 16:43 UTC, Bastien Nocera 		rejected Details | Review

Description Bastien Nocera 2016-06-03 16:43:21 UTC 
.
Comment 1 Bastien Nocera 2016-06-03 16:43:26 UTC 
Created attachment 329069 [details] [review]
build: Fix autogen.sh for builddir != srcdir
Comment 2 Bastien Nocera 2016-06-03 16:43:34 UTC 
Created attachment 329070 [details] [review]
build: Fix -Wformat-y2k compilation errors

The strings are user visible strings, so this isn't a y2k problem.
Comment 3 Bastien Nocera 2016-06-03 16:43:41 UTC 
Created attachment 329072 [details] [review]
build: Fix -Wformat-nonliteral compilation errors

By ignoring the errors when a fix would be too convoluted.
Comment 5 Thomas Haller 2016-06-06 10:47:55 UTC 
Review of attachment 329070 [details] [review]:

I would instead disable this warning via "-Wno-format-y2k" in m4/compiler_options.m4.

I don't think that every warning that gcc provides makes sense for every project (this one IMO doesn't make sense for us).
Comment 6 Thomas Haller 2016-06-06 10:56:12 UTC 
Review of attachment 329072 [details] [review]:

I didn't realize you posted this patch on Friday. So, yesterday, after https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=6725962f83eef3268fa76e8c046997273c4285e4 , compilation was broken on Fedora 23 too. So I already fixed it in https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=466bf2f6332e15a447a40e2a92b7f4493502855a .

Sorry about that overlap.
Comment 7 Beniamino Galvani 2016-06-06 11:44:33 UTC 
(In reply to Thomas Haller from comment #5)
> Review of attachment 329070 [details] [review] [review]:
> 
> I would instead disable this warning via "-Wno-format-y2k" in
> m4/compiler_options.m4.

I agree, the option seems hardly useful.
Comment 8 Thomas Haller 2016-06-06 12:09:18 UTC 
(In reply to Thomas Haller from comment #4)
> Review of attachment 329069 [details] [review] [review]:
> 
> merged to master:
> https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/
> ?id=ed7ee64d4e92f1aad14f53ec8898d1ae0a319c86

hm, this broke build on Ubuntu 12.04. Reverted: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=fa6b1070fcf6ae267e766ca1d2c8de0ac1b85255



(In reply to Beniamino Galvani from comment #7)
> (In reply to Thomas Haller from comment #5)
> > Review of attachment 329070 [details] [review] [review] [review]:
> > 
> > I would instead disable this warning via "-Wno-format-y2k" in
> > m4/compiler_options.m4.
> 
> I agree, the option seems hardly useful.

disabled: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b8b68e212d526fe4c94a6291d21612d4ac1cb094