After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767203 - vaapi: libs: EGL support is dead code since upstream
vaapi: libs: EGL support is dead code since upstream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 766206
Blocks: 736713
 
 
Reported: 2016-06-03 15:26 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-10-05 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libs: egl: remove dynamic library loading code (10.05 KB, patch)
2016-07-13 16:52 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-06-03 15:26:27 UTC 
The EGL support in gstreamer-vaapi relied on dynamic loading of libraries, but we removed all that when gstreamer-vaapi was merged into gstreamer project.

So nowadays, all the EGL code is dead code. Furthermore, EGL was stopped to be tested since commit 200b1baa (march 2015), because it marked EGL as GLX "compatible".

From my point of view, EGL support is not required right now, since dmabuf is enough.

We have three options here:

1\ remove all the egl related bits
2\ hardcoding the egl disabling in configure.ac  
3\ (in parallel with 2) resurrect egl support and finish it
Comment 1 Víctor Manuel Jáquez Leal 2016-07-13 16:52:13 UTC 
Created attachment 331436 [details] [review]
libs: egl: remove dynamic library loading code

Since the upstream of gstreamer-vaapi, the library is not a public shared
object anymore. But the EGL support depended on this dynamic library, so the
EGL support was broken.

This patch removes the dynamic library loading code and instantiates the
EGL display using either X11 or Wayland if available.
Comment 2 Víctor Manuel Jáquez Leal 2016-07-13 16:55:35 UTC 
This patch fixes bug 754680 (at least in my tests)
Comment 3 Víctor Manuel Jáquez Leal 2016-07-27 13:29:40 UTC 
Attachment 331436 [details] pushed as 27429ce - libs: egl: remove dynamic library loading code