After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767156 - good: fix leaks in tests
good: fix leaks in tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-02 11:20 UTC by Guillaume Desmottes
Modified: 2016-06-02 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use MAY_BE_LEAKED flag (2.00 KB, patch)
2016-06-02 11:21 UTC, Guillaume Desmottes 		reviewed Details | Review
amrparse: clean up test (4.87 KB, patch)
2016-06-02 13:03 UTC, Guillaume Desmottes 		committed Details | Review
rtpbin: fix caps leak in test (1.97 KB, patch)
2016-06-02 13:03 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2016-06-02 11:20:52 UTC 
.
Comment 1 Guillaume Desmottes 2016-06-02 11:21:10 UTC 
Created attachment 328940 [details] [review]
use MAY_BE_LEAKED flag
Comment 2 Tim-Philipp Müller 2016-06-02 12:35:31 UTC 
Comment on attachment 328940 [details] [review]
use MAY_BE_LEAKED flag

Nothing wrong with the patch, but I think it would be nicer to rewrite the tests to be less weird, especially the amrparse one.

The rtpbin one could/should perhaps just cache the caps in the CleanupData struct?
Comment 3 Guillaume Desmottes 2016-06-02 13:03:54 UTC 
Created attachment 328951 [details] [review]
amrparse: clean up test

- use GST_CHECK_MAIN() to reduce boilerplate
- unref the input caps using a teardown function to prevent leaks
Comment 4 Guillaume Desmottes 2016-06-02 13:03:58 UTC 
Created attachment 328952 [details] [review]
rtpbin: fix caps leak in test
Comment 5 Tim-Philipp Müller 2016-06-02 13:20:39 UTC 
Awesome, thanks!

commit 57eb9fec72160cd913bb62d1e2e47bb26b07aa6f
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Jun 2 15:03:17 2016 +0200

    tests: rtpbin: fix caps leak
    
    https://bugzilla.gnome.org/show_bug.cgi?id=767156

commit 507e99cb969eaab92dd3686068dd9991574975b2
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Jun 2 15:00:01 2016 +0200

    tests: amrparse: clean up test
    
    - use GST_CHECK_MAIN() to reduce boilerplate
    - unref the input caps using a teardown function to prevent leaks
    
    https://bugzilla.gnome.org/show_bug.cgi?id=767156