After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767108 - Separators not correctly placed in GtkPopover
Separators not correctly placed in GtkPopover
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 417141
 
 
Reported: 2016-06-01 14:01 UTC by Bastien Nocera
Modified: 2016-06-01 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Separators not correctly placed (2.37 KB, patch)
2016-06-01 14:01 UTC, Bastien Nocera
reviewed Details | Review
what it looks like (14.79 KB, image/png)
2016-06-01 14:42 UTC, Bastien Nocera
  Details
what it's supposed to look like (30.49 KB, image/png)
2016-06-01 14:42 UTC, Bastien Nocera
  Details

Description Bastien Nocera 2016-06-01 14:01:08 UTC
Test case attached.
Comment 1 Bastien Nocera 2016-06-01 14:01:13 UTC
Created attachment 328891 [details] [review]
Separators not correctly placed

What it should look like:
  Bold
----
/Size/
  x 0.5
  x 1.0

What it looks like:
  Bold
  /Size/
----
  x 0.5
  x 1.0
Comment 2 Bastien Nocera 2016-06-01 14:42:26 UTC
Created attachment 328896 [details]
what it looks like
Comment 3 Bastien Nocera 2016-06-01 14:42:52 UTC
Created attachment 328897 [details]
what it's supposed to look like
Comment 4 Matthias Clasen 2016-06-01 14:45:30 UTC
I'm not so sure about the 'supposed to'. 

The current look is intentional, at least. We place the label above the separator, treating it like an underline for the title, more or less.

It is certainly possible to change it, either to what you propose, or

--- Size ---

ie put the label in the middle of the separator.
Comment 5 Jakub Steiner 2016-06-01 14:50:03 UTC
I don't think there should be any indentation variation between the regular item labels and headings. All the labels should align. The separators will look good aligning as well, or strethings outside (being wider).
Comment 6 Jakub Steiner 2016-06-01 14:51:47 UTC
Oh and yes, I agree the section heading should be included within the group, ie in your case the separator being above it.
Comment 7 Matthias Clasen 2016-06-01 15:53:29 UTC
Pushed a fix