After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767104 - applemedia: vtenc: Register a hardware-only vtenc_h264_hw element on OSX
applemedia: vtenc: Register a hardware-only vtenc_h264_hw element on OSX
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-01 11:57 UTC by Heinrich Fink
Modified: 2016-06-02 08:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
applemedia: vtenc: Register a hardware-only vtenc_h264_hw element on OSX (3.08 KB, patch)
2016-06-01 11:57 UTC, Heinrich Fink 		committed Details | Review

Description Heinrich Fink 2016-06-01 11:57:24 UTC 
We ran into the use case where we'd like to fall back to x264enc if vtenc
can't actually encode using the hardware encoder on OSX. This patch adds a
vtenc_h264_hw element that would fail to negotiate if hardware resources
couldn't be acquired. We can then catch this, and replace vtenc_h264_hw with
v264enc (which is much faster than the vtenc_h264 software encoder).
Comment 1 Heinrich Fink 2016-06-01 11:57:28 UTC 
Created attachment 328879 [details] [review]
applemedia: vtenc: Register a hardware-only vtenc_h264_hw element on OSX

Similar to vtdec_hw, this commit adds a vtenc_h264_hw element that fails
caps negotiation unless a hardware encoder could actually be acquired.
This is useful in situations where a fallback to a software encoder
other than the vtenc_h264 software encoder is desired (e.g. to x264enc).
Comment 2 Sebastian Dröge (slomo) 2016-06-01 14:07:59 UTC 
Review of attachment 328879 [details] [review]:

Looks good to me
Comment 3 Sebastian Dröge (slomo) 2016-06-02 08:22:26 UTC 
Attachment 328879 [details] pushed as ab70d79 - applemedia: vtenc: Register a hardware-only vtenc_h264_hw element on OSX