After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767091 - Gimp Crashes dragging pattern to overlay layer
Gimp Crashes dragging pattern to overlay layer
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Backend: Quartz
2.24.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-quartz maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-06-01 02:35 UTC by sbg8867
Modified: 2018-04-15 00:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Bug 767091 - Gimp Crashes dragging pattern to overlay layer (3.85 KB, patch)
2016-08-07 14:49 UTC, Kristian Rietveld
none Details | Review

Description sbg8867 2016-06-01 02:35:51 UTC
when I try to drop and drag a pattern from the patterns tab on the dock onto a layer thats an overlay, gimp will crash every single time (it doesnt crash in normal layer mode).  Ive been doing this for years on my PC but now on my new Imac, it crashes every time.  its really disheartening because I got the Imac specifically to do my graphics arts on, and now a main component I use in creating them, I cant use at all.  thanks for any help!!!
Comment 1 André Klapper 2016-06-03 13:29:36 UTC
Which exact OS version is this about? Any crash information?
Comment 2 sbg8867 2016-06-05 02:53:34 UTC
Im on OS X El Capitan version 10.11.5.

It just crashes/shuts down completely.  Not sure where I would find more information on the crash.

Thanks!
Comment 3 Michael Natterer 2016-07-08 21:28:28 UTC
What do you mean by "overlay layer"? A layer in overlay mode? A floating
selection?
Comment 4 sbg8867 2016-07-09 11:23:00 UTC
a transparency layer in overlay mode, as opposed to normal mode.
Comment 5 Michael Natterer 2016-07-09 12:39:41 UTC
Thanks. I can't reproduce this. Can you make it crash reliably?
Is there anything else special about the image?
Comment 6 sbg8867 2016-07-09 12:45:07 UTC
Oh yes it does it every time, no matter what image I am using.  :(
Comment 7 Michael Natterer 2016-07-09 12:56:52 UTC
Ok. Is this the official DMG from gimp.org?

Can anyone reproduce this on a Mac?
Comment 8 Kristian Rietveld 2016-07-09 13:19:28 UTC
I am using the DMG on El Capitan and I cannot reproduce this.

Could you provide us with the following:

- Whether you are using Gimp from the official DMG from gimp.org, or another build of gimp.

- A step by step description how to reproduce the bug, so that we can replay exactly what you are doing.

- The backtrace (list of addresses/functions) from the crash report.
Comment 9 sbg8867 2016-07-09 13:58:17 UTC
yes it is from gimp.org.  and I just went back onto my imac, to write down the step by step and for thie first time ever it is *not* crashing.  Making me feel like an idiot, but it had been crashing up until this point.  Unless maybe there has been an update between now and then, since I havent tried in a while.  I will post back if it crashes again but I am really keeping my fingers crossed that it will *keep* working!!!!  thanks everyone for your time!  Im not doing anything different than I ever have, this is something I've used gimp for for years before the imac.  So not sure why it hasnt worked and why it seems to be working at the moment.

possibly, hopefully resolved!  somehow!  lol
Comment 10 sbg8867 2016-07-09 14:01:12 UTC
ok now I went to do it again and it crashed.  Didnt do anything different.  steps go
Open gimp, open image.  new layer-transparency, change layer from normal to overlay, Open new image, copy for pattern, drag and drop pattern from layers-patterns window.  gimp shuts down.
Comment 11 Kristian Rietveld 2016-07-09 14:54:40 UTC
How do you perform the "copy for pattern" operation? Do you simply perform the copy action and then drag-and-drop the "clipboard" pattern to the layers window?
Comment 12 sbg8867 2016-07-09 14:58:51 UTC
yes.  Its how I have always done.  I am noticing now that it will drop and drag but that sometimes the pointer icon turns to the little dropper icon or the bucket fill icon, seems to be when it crashes.  not sure why it would interchange though.  but if it stays the little square you are dropping and dragging, it *wont* crash.  Maybe its a setting I have to change?  never had this issue on windows so its new to me.  Thanks!
Comment 13 Kristian Rietveld 2016-07-11 11:18:00 UTC
Ok, I have tried some more things. In order to trigger the crash you need to be in regular mode and not in single-window mode. In the regular mode, I can reliably trigger the crash.


Here is some debug output:

---
(GIMP-bin:17065): Gtk-WARNING **: gtk_drag_set_icon_widget is not supported on Mac OS X
**
Gdk:ERROR:GdkQuartzWindow.c:504:update_context_from_dragging_info: assertion failed: (current_context != NULL)
/Applications/GIMP.app/Contents/MacOS/GIMP-bin: terminated: Abort trap: 6

(script-fu:17073): LibGimpBase-WARNING **: script-fu: gimp_wire_read(): error
---


I will need to debug it. Chances are that this is a bug in the GTK+ implementation of drag-and-drop for Mac.
Comment 14 Michael Natterer 2016-07-12 06:09:58 UTC
And I assume this has nothing to do with overlay mode?
Comment 15 Kristian Rietveld 2016-07-13 07:53:40 UTC
I think you are correct, I think the problem is mainly in the drag and drop code.
Comment 16 Kristian Rietveld 2016-08-07 14:44:00 UTC
It is indeed a GTK+ bug. It is sometimes hard to trigger, because this one is timing dependent. Reassigning to GTK+.
Comment 17 Kristian Rietveld 2016-08-07 14:49:56 UTC
Created attachment 332888 [details] [review]
[PATCH] Bug 767091 - Gimp Crashes dragging pattern to overlay layer

The main problem here is that apparently cases exist where 'draggingUpdated' is sent after performDragOperation: (and even after concludeDragOperation:). Therefore, it is necessary to delay the release of the context until 'draggingEnded'.

I have also removed the hard assert in update_context_from_dragging_info(), this is probably never a good idea to do.

I really do not like the fact that current_context is a static variable -- I have left it for now, but I think it would be good to give this code some more love in the GTK+ 3.x branch.
Comment 18 Matthias Clasen 2018-02-10 05:02:27 UTC
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 19 Matthias Clasen 2018-04-15 00:17:52 UTC
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new