Created attachment 328822 [details] [review]
alternateTab: Adjust to gnome-shell changes

The code de-duplication in commit bf8d30603e57b broke the extension,
fix by duplicating the code here now :-(

(It's not really that bad though ...)

Review of attachment 328822 [details] [review]:

I suppose another way to do this would be taking over Main.wm._startSwitcher() and monkey patch a get_name() method on the binding instance that returns what we want and then call the real Main.wm._startSwitcher() with it. Not sure which one is uglier :-P

Attachment 328822 [details] pushed as e98e5d0 - alternateTab: Adjust to gnome-shell changes

(In reply to Rui Matos from comment #2)
> I suppose another way to do this would be taking over
> Main.wm._startSwitcher() and monkey patch a get_name() method on the binding
> instance that returns what we want and then call the real
> Main.wm._startSwitcher() with it. Not sure which one is uglier :-P

I don't think I like

let originName = binding.get_name();
binding.get_name = function() {
    switch (originName) {
        case 'switch-applications':
        case 'switch-group':
            return 'switch-windows';
        case 'switch-applications-backwards':
        case 'switch-group-backwards':
            return 'switch-windows-backwards';
        default:
            return originName;
}

very much, so going with my original patch :-)