GNOME Bugzilla – Bug 767053
nlecomposition: Fix race condition in seek handling causing deadlocks
Last modified: 2016-06-01 17:55:01 UTC
See commit message
Created attachment 328784 [details] [review] nlecomposition: Fix race condition in seek handling causing deadlocks We might receive another seek from the application while the action task is handling a previous seek (and thus setting seeking_itself to TRUE). To prevent this seek to go through directly instead of being added as an action, also check if the seek event was received from our action task thread or some other thread.
Created attachment 328785 [details] ges-testcase.c This deadlocks after a lot of scrub seeking with the seekbar, the attached patch fixes this.
Review of attachment 328784 [details] [review]: Sounds good.
Attachment 328784 [details] pushed as 2ef72b7 - nlecomposition: Fix race condition in seek handling causing deadlocks
Should this also go into 1.8.2?
How confident are you that it does not introduce regression? :)
If I understand how nlecomposition works with the task/actions, then I'm sure that this won't break anything that wasn't broken before