After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767012 - object: leak in test_fake_object_name
object: leak in test_fake_object_name
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-30 09:29 UTC by Guillaume Desmottes
Modified: 2016-06-20 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
object: fix object reference leak in test_fake_object_name (886 bytes, patch)
2016-05-30 09:30 UTC, Guillaume Desmottes 		none Details | Review

Description Guillaume Desmottes 2016-05-30 09:29:54 UTC 
.
Comment 1 Guillaume Desmottes 2016-05-30 09:30:12 UTC 
Created attachment 328714 [details] [review]
object: fix object reference leak in test_fake_object_name

gst_object_set_parent() takes a reference on the child which should be
dropped using gst_object_unparent().
Comment 2 Tim-Philipp Müller 2016-06-20 10:39:01 UTC 
This seems to have been fixed by

commit f2fd3bda2bf5d2d77d2acc1584806ff615533591
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Mon May 30 13:42:36 2016 +0200

    gstobject: split up name tests
    
    It is better to have separate tests:
    1) the test name will tell what is broekn when the test fails
    2) we still run the other tests when one assert fails
    3) the tests are easier to understand
    4) we don't rely on sie effect of previous actions
    5) ...
    
    Also ix the assertion message for the name checks (Gst -> fakeobject).


(now in test_fake_object_set_name_when_parented)