GNOME Bugzilla – Bug 766973
Various warningfixes for OSX (10.9.5) compiling with Apple LLVM version 6.0
Last modified: 2016-06-03 05:48:38 UTC
Created attachment 328675 [details] [review] patch A collection of patches
Created attachment 328676 [details] [review] patch
Created attachment 328677 [details] [review] gstgltestsrc
Created attachment 328678 [details] [review] gstglquery
Created attachment 328679 [details] [review] avsamplevideosink
Comment on attachment 328679 [details] [review] avsamplevideosink >+#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && \ >+ MAC_OS_X_VERSION_MAX_ALLOWED >= 1010 && \ >+ defined(MAC_OS_X_VERSION_MIN_REQUIRED) && \ >+ MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_4 this should be like that and not ... && (!defined(min_req) || (defined (min_req) && min_req <= 10_4)) right? (I have no opinion, just making sure..)
Comment on attachment 328678 [details] [review] gstglquery pushed after gst-indent
(In reply to Tim-Philipp Müller from comment #5) > Comment on attachment 328679 [details] [review] [review] > avsamplevideosink > > >+#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && \ > >+ MAC_OS_X_VERSION_MAX_ALLOWED >= 1010 && \ > >+ defined(MAC_OS_X_VERSION_MIN_REQUIRED) && \ > >+ MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_4 > > this should be like that and not > > ... && (!defined(min_req) || (defined (min_req) && min_req <= 10_4)) > > right? (I have no opinion, just making sure..) hgr 23:59 __tim: about your comment, I think the min-max version stuff is right, because it must be 10.4 or lower AND it must be 10.1 or higher… :) hgr 00:00 with OR 10.0 and 10.5 would both be valid
Fair enough, let's get those in then. What are build bots for otherwise.. commit f615a84646ea581a5048f29a0c81a27917518767 Author: Havard Graff <havard.graff@gmail.com> Date: Sat May 28 21:34:52 2016 +0200 applemedia: CGLTexImageIOSurface2D needs the OpenGL framework on OSX https://bugzilla.gnome.org/show_bug.cgi?id=766973 commit ba06fc96b721bdbed06705240208169567a99dfa Author: Havard Graff <havard.graff@gmail.com> Date: Sat May 28 21:39:00 2016 +0200 avsamplevideosink: check we are compiling for 10.1 up to 10.4 This API was deprecated in 10.4, so don't use it for 10.5 and onwards. https://bugzilla.gnome.org/show_bug.cgi?id=766973
The framework commit broke the build on our build bot: .1/workdir/dist/ios_universal/lib/libintl.dylib -liconv -lc -g -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk -mios-simulator-version-min=6.0 -g -Os -Wl,-framework -Wl,CoreFoundation -Wl,-framework -Wl,CoreMedia -Wl,-framework -Wl,CoreVideo -Wl,-framework -Wl,OpenGL -Wl,-framework -Wl,AudioToolbox -Wl,-framework -Wl,Foundation -Wl,-framework -Wl,AssetsLibrary -Wl,-framework -Wl,AVFoundation -Wl,-weak_framework -Wl,VideoToolbox -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk -mios-simulator-version-min=6.0 -Wl,-ios_simulator_version_min -Wl,6.0 -Wl,-undefined -Wl,error -Wl,-headerpad_max_install_names -framework OpenGLES -framework QuartzCore -framework UIKit -framework CoreGraphics -framework CoreFoundation -framework Foundation -Wl,-exported_symbols_list,.libs/libgstapplemedia-symbols.expsym 23:27:58 ld: framework not found OpenGL 23:27:58 clang: error: linker command failed with exit code 1 (use -v to see invocation) 23:27:58 make[3]: *** [libgstapplemedia.la] Error 1 23:27:58 make[2]: *** [applemedia] Error 2 23:27:58 make[1]: *** [all-recursive] Error 1 https://ci.gstreamer.net/job/cerbero-ios-universal-7.1/4424/console https://ci.gstreamer.net/job/cerbero-ios-universal-7.1/4424/
commit 09e3bd0fb33e41e496323e88ad25aa227d5f61a1 Author: Edward Hervey <bilboed@bilboed.com> Date: Fri Jun 3 07:11:33 2016 +0200 applemedia: Only use the OpenGL framework on OSX It's not available on ios (uses OpenGLES already) https://bugzilla.gnome.org/show_bug.cgi?id=766973
Thanks, Ed! :)