After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766899 - Superflous HTML/XML comments in GDBusProxyTypeFunc documentation string
Superflous HTML/XML comments in GDBusProxyTypeFunc documentation string
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.48.x
Other All
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-05-26 08:16 UTC by jonatan.p
Modified: 2016-07-17 00:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Apply using "patch -o0" (419 bytes, patch)
2016-05-26 08:16 UTC, jonatan.p 		none Details | Review
Created using "git --format-patch" (834 bytes, patch)
2016-05-26 08:17 UTC, jonatan.p 		committed Details | Review

Description jonatan.p 2016-05-26 08:16:53 UTC 
Created attachment 328547 [details] [review]
Apply using "patch -o0"

There are some HTML/XML comments in the docstring for GDBusProxyTypeFunc. Attached is a patch generated using "diff -u" (fix-docstring-for-GDBusProxyTypeFunc.patch) as per "Submitting patches" instructions, and I will try to add an additional git patch (0001-docs-Remove-superflous-XML-comments-in-doc-string-fo.patch).

Are "git --format-patch" patches OK to submit, or is "diff -u" preferred?
Comment 1 jonatan.p 2016-05-26 08:17:44 UTC 
Created attachment 328548 [details] [review]
Created using "git --format-patch"
Comment 2 Matthias Clasen 2016-05-26 13:05:01 UTC 
Review of attachment 328548 [details] [review]:

looks good, thanks