After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766881 - An extranous separator is shown in OSM types recent list
An extranous separator is shown in OSM types recent list
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-25 19:22 UTC by Marcus Lundblad
Modified: 2016-09-02 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Before (17.88 KB, image/png)
2016-05-25 19:22 UTC, Marcus Lundblad 		  Details
After (17.87 KB, image/png)
2016-05-25 19:23 UTC, Marcus Lundblad 		  Details
osmEditDialog: Avoid adding an extra separator in recent types list (1.00 KB, patch)
2016-05-25 19:23 UTC, Marcus Lundblad 		committed Details | Review

Description Marcus Lundblad 2016-05-25 19:22:31 UTC 
Created attachment 328524 [details]
Before

Before the first item in the list box showing recently used OSM types a separator is drawn at the top, giving a visual glitch.

See attached screenshots before and after the fix.
Comment 1 Marcus Lundblad 2016-05-25 19:23:05 UTC 
Created attachment 328525 [details]
After
Comment 2 Marcus Lundblad 2016-05-25 19:23:41 UTC 
Created attachment 328526 [details] [review]
osmEditDialog: Avoid adding an extra separator in recent types list

Don't add a separator before the first item in the recent types list when setting
a type for a POI.
Comment 3 Nayan Deshmukh 2016-06-09 07:03:54 UTC 
Review of attachment 328526 [details] [review]:

LGTM
Comment 4 Jonas Danielsson 2016-09-02 19:35:04 UTC 
Attachment 328526 [details] pushed as 359d44e - osmEditDialog: Avoid adding an extra separator in recent types list