After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766732 - openjpegenc: Doesn't manage MCT switch for RGB and YUV frames
openjpegenc: Doesn't manage MCT switch for RGB and YUV frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-20 18:27 UTC by Aaron Boxer
Modified: 2016-05-25 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Enable MCT for RGB video (844 bytes, patch)
2016-05-20 21:32 UTC, Aaron Boxer
committed Details | Review

Description Aaron Boxer 2016-05-20 18:27:27 UTC
MCT is the J2K transform to convert RGB to YUV.
If the frame is already in YUV format, then this transform does not need to be performed.  

So, when setting up the encoder, MCT should be zero for YUV colour spaces, and it should equal 1 for RGB colour spaces.
Comment 1 Aaron Boxer 2016-05-20 18:32:26 UTC
In fact, it looks like the encoder simply always uses the default MCT setting,
which is zero (no MCT).  This is not efficient for RGB colour spaces, as the MCT
decorrelates the colour channels, resulting in more efficient encoding.
Comment 2 Aaron Boxer 2016-05-20 19:35:17 UTC
Fixed in patch to #766732
Comment 3 Tim-Philipp Müller 2016-05-20 20:20:11 UTC
Hrm? This is bug #766732.
Comment 4 Aaron Boxer 2016-05-20 21:32:18 UTC
Created attachment 328292 [details] [review]
Enable MCT for RGB video

Here is the patch that fixes this issue.
Comment 5 Tim-Philipp Müller 2016-05-20 21:34:31 UTC
Thanks.
Comment 6 Sebastian Dröge (slomo) 2016-05-21 06:44:52 UTC
commit e76705dbde5d25fbc0fa528bbb89989be00773cb
Author: Aaron Boxer <boxerab@gmail.com>
Date:   Fri May 20 17:28:52 2016 -0400

    openjpegenc: enable MCT for RGB video
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766732