After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766710 - Leftover gtk+-x11 dependency
Leftover gtk+-x11 dependency
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks: wayland
 
 
Reported: 2016-05-20 11:58 UTC by Quentin "Sardem FF7" Glidic
Modified: 2016-06-19 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove the gtk+-x11 dependency for the Nautilus extension (1.13 KB, patch)
2016-05-20 12:00 UTC, Quentin "Sardem FF7" Glidic 		committed Details | Review

Description Quentin "Sardem FF7" Glidic 2016-05-20 11:58:58 UTC 
I think the gtk+-x11 check for the Nautilus extension is a leftover from a very long time ago. No X11 header is required, nor gdkx.h, and Nautilus only uses X11 stuff in a corner case (eel), which could be patched out on system without X11 at all.

I think it is safe to remove that dependency now, I will provide a patch for that.
Comment 1 Quentin "Sardem FF7" Glidic 2016-05-20 12:00:12 UTC 
Created attachment 328253 [details] [review]
Patch to remove the gtk+-x11 dependency for the Nautilus extension

If you want to bump the nautilus dependency to make sure it will only work with newer (X11-free) Nautilus, please tell me and I will update the patch.
Comment 2 Germán Poo-Caamaño 2016-05-20 12:07:30 UTC 
(In reply to Quentin "Sardem FF7" Glidic from comment #1)
> Created attachment 328253 [details] [review] [review]
> [...]
> If you want to bump the nautilus dependency to make sure it will only work
> with newer (X11-free) Nautilus, please tell me and I will update the patch.

Which nautilus version would that be?
Comment 3 Carlos Garcia Campos 2016-06-19 11:46:17 UTC 
Comment on attachment 328253 [details] [review]
Patch to remove the gtk+-x11 dependency for the Nautilus extension

Pushed, thanks!