After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766623 - [review] vpn-plugin-split for nm-libreswan and nm-pptp [th/vpn-editor-split-bgo766623]
[review] vpn-plugin-split for nm-libreswan and nm-pptp [th/vpn-editor-split-b...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN (general)
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-05-18 19:00 UTC by Thomas Haller
Modified: 2016-05-23 07:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Thomas Haller 2016-05-18 19:00:45 UTC
Like done for nm-vpnc and nm-openvpn, now also for nm-libreswan and nm-pptp.

- split the libnm plugin in a core and GTK part.
- add shared directory
- move files around and adjust makefiles.


Afterwards, the result looks similar to what is on nm-openvpn (bug 765732) nm-vpnc (bgo 766170).


(yes, for pptp the core-part is pretty empty and the core-part itself has almost no functionality yet. I think this split will have more use in the future, as nmcli already now can use the core-plugin. So there is more incentive to extend the core-plugin. The plugin split is a prerequisite for that).
Comment 2 Thomas Haller 2016-05-22 09:55:04 UTC
reminder: nm-pptp doesn't have supports-multiple-connections (--bus-name) yet. Will be added after merging this branch.
Comment 4 Thomas Haller 2016-05-23 07:18:34 UTC
(In reply to Thomas Haller from comment #2)
> reminder: nm-pptp doesn't have supports-multiple-connections (--bus-name)
> yet. Will be added after merging this branch.

no, it's already there. Just missed it.